Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-41834: Add agent installer checks for hosts interface table #9052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-41834: Add agent installer checks for hosts interface table #9052

wants to merge 1 commit into from
+67 −3

Conversation

bfournie
Copy link
Contributor

Add checks for the host interface table to validate:

  • at least one entry is defined in the interface table when using network configuration
  • the MAC addresses in the interface table are using the expected format

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 24, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-41834, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add checks for the host interface table to validate:

  • at least one entry is defined in the interface table when using network configuration
  • the MAC addresses in the interface table are using the expected format

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 24, 2024
@bfournie bfournie force-pushed the agent-int-table-check branch 2 times, most recently from 4bafe2a to 7c4c98b Compare September 24, 2024 16:43
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bfournie. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie
Copy link
Contributor Author

/cc @andfasano

@bfournie
OCPBUGS-41834: Add agent installer checks for hosts interface table
df4120d 
Add checks for the host interface table to validate:
- at least one entry is defined in the interface table when using
  network configuration
- the MAC addresses in the interface table are using the expected format
@bfournie
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-add-nodes df4120d link false /test e2e-agent-compact-ipv4-add-nodes
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage df4120d link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/okd-e2e-agent-compact-ipv4 df4120d link false /test okd-e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhanss mhanss Awaiting requested review from mhanss

@rwsu rwsu Awaiting requested review from rwsu

@zaneb zaneb Awaiting requested review from zaneb

@andfasano andfasano Awaiting requested review from andfasano

Assignees
No one assigned
Labels
jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfournie @openshift-ci-robot