OCPBUGS-42483: PowerVS: update capi ibmcloud c6bcd313 for 4.17 #9054
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@hamzy: This pull request references Jira Issue OCPBUGS-42483, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@hamzy: This pull request references Jira Issue OCPBUGS-42483, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @r4f4 |
| k8s.io/cloud-provider-vsphere v1.30.1 | ||
| k8s.io/klog v1.0.0 | ||
| k8s.io/klog/v2 v2.120.1 | ||
| k8s.io/utils v0.0.0-20240310230437-4693a0247e57 | ||
| libvirt.org/go/libvirtxml v1.10002.0 | ||
| sigs.k8s.io/cluster-api v1.7.3 | ||
| sigs.k8s.io/cluster-api v1.8.2 |
There was a problem hiding this comment.
We should also bump the capi binary to the same version in cluster-api/cluster-api. Building against one version and running another is asking for trouble.
When we bump, we need to make sure all the other providers still work, so this PR needs to be thoroughly tested.
There was a problem hiding this comment.
I don't see the update. Maybe you forgot to push the new commit?
There was a problem hiding this comment.
Weird. It is here locally and was pushed.
hamzy:hamzy-installer$ grep 'sigs.k8s.io/cluster-api v1.8.2' go.mod
sigs.k8s.io/cluster-api v1.8.2
hamzy:hamzy-installer$ git status
On branch PowerVS-Update-417-CAPI-ibmcloud-c6bcd313
Your branch is up to date with 'origin/PowerVS-Update-417-CAPI-ibmcloud-c6bcd313'.
There was a problem hiding this comment.
Forgot to also modify cluster-api/cluster-api/go.mod :(
Thanks!
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hamzy
force-pushed
the
PowerVS-Update-417-CAPI-ibmcloud-c6bcd313
branch
from
8a3cf7b
to
8536700
Compare
hamzy
force-pushed
the
PowerVS-Update-417-CAPI-ibmcloud-c6bcd313
branch
from
8536700
to
6240605
Compare
|
/retest-required |
|
/hold Let's fix the capi mismatch in the master branch first. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-powervs-ovn |
|
Fix proposed in #9055 |
|
/test e2e-ibmcloud-ovn |
|
@hamzy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-powervs-ovn |
Update the installer to use commit c6bcd313bce0fc9866e41bb9e3487d9f61c628a3 of cluster-api-provider-ibmcloud
This includes a couple of necessary Transit Gateway fixes.