Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE The resulted ICSP should contain details for all operators not just for newly added #597

Open
stefanvasilic4 opened this issue Mar 28, 2023 · 12 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@stefanvasilic4
Copy link

Version

latest

What happened?

When adding a new operator or change maxVersion in imagesetconfiguration the resulting ICSP has only the new operator details.

What did you expect to happen?

I expect the new ICSP to contain details of existing operators plus the new operator's details, added to imagesetconfiguration

@pwcazenave
Copy link

This has caught me in the past - having only the details for the operators that were updated instead of all the requested operators means I have to manually merge my ICSP configs after mirroring.

@ChristianLoewel
Copy link

Same for me - I have set the --ignore-history parameter to always mirror the complete catalog to ensure that removed ICSP entries are not lost, although this unnecessarily increases the runtime of oc-mirror.

@sushil-telus
Copy link

Same here. Waiting on the feature to be implement.

I tried to make use of the --manifests-only option but it doesn't work if i am using the tool to copy images from image registry to image registry.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2023
@sushil-telus
Copy link

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2023
@mnorrsken
Copy link

I have the same problem, as we are using gitops to update the ICSPs in the cluster

@dadav
Copy link

dadav commented Nov 29, 2023

We have the same problem. We run oc-mirror daily and therefore have dozens of results directory with manifests which same names (e.g. operator-0). So if I apply these manifests which only contain a subset of the needed informations, everything else is lost.

@sjbylo
Copy link

sjbylo commented Feb 13, 2024

I have the same problem, as we are using gitops to update the ICSPs in the cluster

Same also.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 14, 2024
@sushil-telus
Copy link

Looks like this is implemented

Ref:

Well I haven't tested it yet. (just in case anybody else is desperate for an update.)

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

8 participants