Update nw-ingress-configuring-application-domain.adoc #96043
Conversation
openshift-ci
bot
added
the
size/XS
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
xenolinux
added
peer-review-in-progress
xenolinux
added
peer-review-done
|
cc @jldohmann |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/label merge-review-needed |
openshift-ci
bot
added
merge-review-needed
|
@lcavalle: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Peer-reviewed again by mistake, soree. |
|
/remove-label merge-review-needed |
openshift-ci
bot
added
size/S
Wrong structure of command needs to be corrected Here is the documentation link: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/networking-operators#nw-ingress-configuring-application-domain_configuring-ingress Here is the current look: Expose the route: $ oc expose service hello-openshift route.route.openshift.io/hello-openshift exposed The above command is not structured properly. We can use the above command as well, and it will execute perfectly. But its structure is not as per our standard procedure. Hence, it needs to be changed. Here is the updated look: Expose the route: $ oc expose service hello-openshift route.route.openshift.io/hello-openshift exposed [new-commit]Update nw-ingress-configuring-application-domain.adoc [new-commit]Update nw-ingress-configuring-application-domain.adoc [new-change]Update nw-ingress-configuring-application-domain.adoc [new-change]Update nw-ingress-configuring-application-domain.adoc
|
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
skopacz1
added
the
merge-review-in-progress
There was a problem hiding this comment.
Merge review LGTM, I only left one comment but I won't stop the merging over this nit. If you are interested you can make that change in a follow up PR (and if you do make a follow up PR, another good thing to fix would be making sure that every step in this module has the "by running the following command" language if it has a command to run)
| ---- | ||
| + | ||
| .Example output | ||
| [source,text] |
There was a problem hiding this comment.
This ideally should be terminal but I will not stop the merge review over this:
| [source,text] | |
| [source,terminal] |
|
/cherrypick enterprise-4.16 |
|
@skopacz1: new pull request created: #96276 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96277 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96278 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96279 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #96280 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/networking-operators#nw-ingress-configuring-application-domain_configuring-ingress Here is the current look:
Expose the route:
Here is the updated look:
Expose the route:
Version(s):
RHOCP 4.20, RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16
Issue:
https://issues.redhat.com/browse/OSDOCS-15294
Link to docs preview:
https://96043--ocpdocs-pr.netlify.app/openshift-dedicated/latest/networking/networking_operators/ingress-operator.html
https://96043--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/ingress-operator.html
https://96043--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/networking_operators/ingress-operator.html
QE review:
Additional information: