Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: ci/prow-entrypoint.sh: don't use grep -q at the end of pipeline #1485

Merged
merged 1 commit into from
Apr 15, 2024
Merged

NO-JIRA: ci/prow-entrypoint.sh: don't use grep -q at the end of pipeline #1485

merged 1 commit into from
Apr 15, 2024

Commits on Apr 15, 2024

  1. ci/prow-entrypoint.sh: don't use grep -q at the end of pipeline 

    Unlike `grep`, `grep -q` will exit 0 as soon as a match is found. This
will cause whatever is writing into `grep` to hit `SIGPIPE`. And if it's
not equipped to handle that signal, it'll be terminated and the overall
if-condition will always fail due to `-o pipefail`.

See also ostreedev/ostree#3203.
    @jlebon
    jlebon committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3459323 View commit details
    Browse the repository at this point in the history