Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opendatahub/vllm: include adapter smoke test for main #52662

Merged
merged 2 commits into from
Jun 10, 2024
Merged

opendatahub/vllm: include adapter smoke test for main #52662

merged 2 commits into from
Jun 10, 2024

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented May 31, 2024 •
edited
Loading

Enables grpc server smoke test for main branch

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2024
@dtrifiro dtrifiro marked this pull request as ready for review May 31, 2024 11:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2024
@heyselbi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@dtrifiro
Copy link
Contributor Author

dtrifiro commented Jun 4, 2024

/retest

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Jun 4, 2024

Merge after #52543 and opendatahub-io/vllm#3

@dtrifiro dtrifiro force-pushed the opendatahub-vllm-main-include-adapter-smoke-test branch from d1e1378 to 91f0e9a Compare June 4, 2024 12:52
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dtrifiro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-vllm-main-smoke-test opendatahub-io/vllm presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

z103cb
z103cb reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Jun 5, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@dtrifiro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Jun 7, 2024

/retest

@dtrifiro
Copy link
Contributor Author

/pj-rehearse pull-ci-opendatahub-io-vllm-main-smoke-test

@openshift-ci-robot
Copy link
Contributor

@dtrifiro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@heyselbi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, heyselbi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@heyselbi
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@heyselbi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

@dtrifiro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 69bb279 into openshift:master Jun 10, 2024
16 checks passed
@dtrifiro dtrifiro deleted the opendatahub-vllm-main-include-adapter-smoke-test branch June 11, 2024 21:11
shakyav pushed a commit to shakyav/release that referenced this pull request Jun 12, 2024
@dtrifiro
opendatahub/vllm: include adapter smoke test for main (openshift#52662)
ee66498 
* opendatahub-io/vllm: use Dockerfile.ubi for main branch

* opendatahub-io/vllm: add grpc test to main branch smoke test
lihongyan1 pushed a commit to lihongyan1/release that referenced this pull request Jun 20, 2024
@dtrifiro @lihongyan1
opendatahub/vllm: include adapter smoke test for main (openshift#52662)
e536dbf 
* opendatahub-io/vllm: use Dockerfile.ubi for main branch

* opendatahub-io/vllm: add grpc test to main branch smoke test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z103cb z103cb z103cb left review comments

@terrytangyuan terrytangyuan terrytangyuan left review comments

@vaibhavjainwiz vaibhavjainwiz Awaiting requested review from vaibhavjainwiz

Assignees

@heyselbi heyselbi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dtrifiro @heyselbi @openshift-ci-robot @terrytangyuan @z103cb