Render engine plugin settings missing in the geometry report

[hlg]

Currently, the geometry creation report does not display all render engine settings. For example opensourceBIM/IfcOpenShell-BIMserver-plugin commit cc68637 introduced a new setting. We want to see a list of all render engine settings in the report. This can be achieved by iterating over renderEngine.getSettings().getParameters() and adding the name and value of each parameter to the report, around here:

BIMserver/BimServer/src/org/bimserver/geometry/StreamingGeometryGenerator.java

Lines 241 to 254 in 0ee3d93

	// TODO there must be a cleaner way of getting this info, since it's in the database...
	// The render engine plugin settings from the database are here: renderEngine.getSettings();
	// But the layerset handling and quantity calculation must not necessarily be configurable and if it is
	// then the plugin can name the settings randomly. But for the report, all the settings should be used.
	RenderEngine engine = renderEnginePool.borrowObject();
	try {
	applyLayerSets = engine.isApplyLayerSets();
	report.setApplyLayersets(applyLayerSets);
	calculateQuantities = engine.isCalculateQuantities();
	report.setCalculateQuantities(calculateQuantities);
	} finally {
	renderEnginePool.returnObject(engine);
	}

Some more information for later reference: Contrary to the render engine attributes applyLayerSets and calculateQuantities, the new attribute is not used in the GeometryRunner and StreamingGeometryGenerator, and thus not necessary to keep it as a property of the any render engine implementation. The keeping of calculateQuantities as a render engine property might also deserve a review and refactoring.