You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the geometry creation report does not display all render engine settings. For example opensourceBIM/IfcOpenShell-BIMserver-plugin commit cc68637 introduced a new setting. We want to see a list of all render engine settings in the report. This can be achieved by iterating over renderEngine.getSettings().getParameters() and adding the name and value of each parameter to the report, around here:
Some more information for later reference: Contrary to the render engine attributes applyLayerSets and calculateQuantities, the new attribute is not used in the GeometryRunner and StreamingGeometryGenerator, and thus not necessary to keep it as a property of the any render engine implementation. The keeping of calculateQuantities as a render engine property might also deserve a review and refactoring.
The text was updated successfully, but these errors were encountered:
* improve the earlier solution to #1323
* separate general (implementation independent) engine settings from
implementation-specific user settings. This involves bringing back the
engine settings "calculateQuantities" and "applyLayersets". If these
are user-configured in a render engine plugin implementation like in
the IfcOpenShell plugin, then they are intentionally show twice.
* account for all possible setting definitions, including nested
array/object types). To test we need a sample plugin implementation
with complex setting definition.
* TODO: implement the full conversion in PluginConfiguration and use
this as a helper.
Currently, the geometry creation report does not display all render engine settings. For example opensourceBIM/IfcOpenShell-BIMserver-plugin commit cc68637 introduced a new setting. We want to see a list of all render engine settings in the report. This can be achieved by iterating over
renderEngine.getSettings().getParameters()
and adding the name and value of each parameter to the report, around here:BIMserver/BimServer/src/org/bimserver/geometry/StreamingGeometryGenerator.java
Lines 241 to 254 in 0ee3d93
Some more information for later reference: Contrary to the render engine attributes
applyLayerSets
andcalculateQuantities
, the new attribute is not used in the GeometryRunner and StreamingGeometryGenerator, and thus not necessary to keep it as a property of the any render engine implementation. The keeping of calculateQuantities as a render engine property might also deserve a review and refactoring.The text was updated successfully, but these errors were encountered: