-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use longer domain as canonical to reinforce correct name #120
Comments
e.g. #111 (comment) |
As part of the problem I'm obviously in favor :) |
A lot of people are using “OSS Pledge”:
I think using opensourcepledge.com is the best way to avoid confusion. Any potential cons? Longer to type? |
We use osspledge.com on the billboards/ooh because the full opensourcepledge.com is too long for that format. But the OOH campaign is ephemeral and I think everywhere else we should use the full URL consistently |
Okay! Let's do it. |
Okay, here we go: [todo moved to ticket description] Anything else? |
@vladh README and a few other places: https://github.com/search?q=repo%3Aopensourcepledge%2Fosspledge.com%20osspledge&type=code |
Done in #123 |
@chadwhitacre When creating redirects, we'll have to do things differently than we have so far. Currently, https://opensourcepledge.com redirects to https://osspledge.com. But https://opensourcepledge.com/members 404s instead of redirecting to https://osspledge.com/members. So when changing the redirects now, we want to be sure that https://osspledge.com/foo/bar will redirect to https://opensourcepledge.com/foo/bar otherwise we'll have a lot of broken links. |
Agreed. If we want to support a handful of existing URLs that's one thing, if we want to support all present and future URLs that another, need something dynamic or double-build or some such. We have another repo for the other domain atm. |
FWIW, I'd point osspledge.com to an HTTP server that does an appropriate rewrite. |
Use case for val.town? |
@chadwhitacre Neat idea! Here you go: https://www.val.town/v/vladh/opensourcepledgeRedirect Example: https://vladh-opensourcepledgeredirect.web.val.run/foo/bar |
Nice! @stevekrouse Any chance you want to donate a pro subscription to Pledge so we can set this up with our custom domain? 😬 🙇♂️ Then you could add that in |
This is awesome! Thanks for thinking of us! I'd love to help out - just checking with the team about the logistics of donating an account. We haven't done that yet and I'm not sure how it'd work in our database/stripe |
Thanks @stevekrouse! If it's a pain I can just pay for it for now. 🙃 |
Apparently it's very easy for us to toggle in our database, so just let me know the username of the account you want upgraded. Is it @vladh? |
Thanks so much @stevekrouse! I'm happy to use my account for this, but maybe @chadwhitacre would like to do something else? Just checking. |
Go for it @vladh. Thanks @stevekrouse! |
If there's some sort of org or team account on val.town maybe we can use that? Otherwise I'm fine w/ vladh for now. |
Great! We don't have teams yet |
Works! https://osp-redir-test.vlad.website/foo/bar (This should redirect to https://opensourcepledge.com/foo/bar, which 404s.) Thanks again @stevekrouse! 🙏🏻 @chadwhitacre When you're ready, here's what needs to be set up for
|
I need to run the DNS change through Sentry Ops, will do that next week. For now I've added manual redirects in the tmp-osspledge-redirect repo and flipped the switch in GitHub CNAME files. |
Seems to be working? |
Oh wow, thanks for doing all that manually. |
This 404s, FWIW: https://osspledge.com/osspledge.pdf (Maybe it doesn't matter) |
I mean, it wasn't fully manual. ;-) import csv, os
members = csv.reader(open('../opensourcepledge.com/members.csv'))
for slug, url in members:
fp = open(f'members/{slug}/index.html', 'w+')
print(f'''
<meta http-equiv="refresh" content="0; URL='https://opensourcepledge.com/members/{slug}/'" />''', file=fp) |
I made a PR 🔒 to update the |
Yep sounds good! 💃🏻 |
We recently transferred osspledge.com and fair.io from my personal Plausible account to Sentry's corp account. I'm supposed to have admin access still but I'm not seeing them in the dashboard. I've pinged internally about that, will follow up when I have it ... |
Plausible should be good: https://plausible.io/opensourcepledge.com. |
DNS change deployed, wfm: https://osspledge.com/random/path/redirects/to/opensourcepledge.com I think we're done here? |
Still waiting for propagation everywhere but seeing it some places. Closing! |
We continually see people using "OSS Pledge" as the name vs. "Open Source Pledge." Some of this confusion is likely unavoidable, but using the short domain as canonical surely doesn't help. Let's think about using the longer one as canonical.
To Do
opensourcepledge.com
repo totmp-osspledge-redirect
with manual redirects. (@chadwhitacre)osspledge.com
GitHub repo toopensourcepledge.com
(@chadwhitacre)The text was updated successfully, but these errors were encountered: