Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation / Security Warning #30

Open
szanni opened this issue Oct 10, 2018 · 2 comments
Open

Documentation / Security Warning #30

szanni opened this issue Oct 10, 2018 · 2 comments

Comments

@szanni
Copy link

szanni commented Oct 10, 2018

I strongly believe that there should be a security warning in the README regarding malicious input.
There is currently no code to verify buffers/structures, unless I missed something completely?
I think a small notice like #29 should suffice.

Any program will crash horrendously should it encounter malicious/corrupted input. If anyone is interested, I adjusted the included tests/examples to be used with american fuzzy lop here. You can test with make fuzz-mem and make fuzz-fp.

@fluffysquirrels
Copy link
Collaborator

fluffysquirrels commented Apr 22, 2019

I added a warning as you describe in #29. Thank you for the suggestion.

Thank you for testing the library! Do you have any proposed fixes for the problems you found?

@szanni
Copy link
Author

szanni commented Mar 6, 2020

Late reply but here it goes: as already noted in the security warning: bounds checks.
Then there are other things to consider like DOS attacks, how big of a list do you really want to decode? This is not a problem that is easily solvable. There used to be a document with recommendations on the official website but I can't seem to find it right now!!?

As with regards to at least implementing said fixes: I sadly don't have the time to come up with something truly robust and secure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants