From 0cd273e64e24564ea603bf5f3234d7db3c125ce0 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 26 Jun 2023 07:23:46 -0300 Subject: [PATCH 01/36] bgp: Using variable after free --- bgpd/bgp_bfd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bgpd/bgp_bfd.c b/bgpd/bgp_bfd.c index 21864cf1a6..dcc707452a 100644 --- a/bgpd/bgp_bfd.c +++ b/bgpd/bgp_bfd.c @@ -320,8 +320,10 @@ static void bgp_peer_remove_bfd(struct peer *p) return; } - if (p->bfd_config) - bfd_sess_free(&p->bfd_config->session); + if (p->bfd_config) { + bfd_sess_free(&p->bfd_config->session); + p->bfd_config->manual = false; + } XFREE(MTYPE_BFD_CONFIG, p->bfd_config); } From f0bfb320efbd7ef0605298ed5298a6f8b148a508 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 26 Jun 2023 07:26:23 -0300 Subject: [PATCH 02/36] bgp: Using variable after free --- bgpd/bgp_bfd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bgpd/bgp_bfd.c b/bgpd/bgp_bfd.c index dcc707452a..85d4035a17 100644 --- a/bgpd/bgp_bfd.c +++ b/bgpd/bgp_bfd.c @@ -320,10 +320,8 @@ static void bgp_peer_remove_bfd(struct peer *p) return; } - if (p->bfd_config) { + if (p->bfd_config) bfd_sess_free(&p->bfd_config->session); - p->bfd_config->manual = false; - } XFREE(MTYPE_BFD_CONFIG, p->bfd_config); } From 01fcb578d5fa069d210d46573091a44ac4d809b6 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 12 Oct 2023 07:58:51 -0300 Subject: [PATCH 03/36] doc: long line --- ospfd/ospf_ase.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/ospfd/ospf_ase.c b/ospfd/ospf_ase.c index 610b5fc08e..13b7b61c26 100644 --- a/ospfd/ospf_ase.c +++ b/ospfd/ospf_ase.c @@ -88,9 +88,7 @@ struct ospf_route *ospf_find_asbr_route(struct ospf *ospf, return best; } -struct ospf_route *ospf_find_asbr_route_through_area(struct route_table *rtrs, - struct prefix_ipv4 *asbr, - struct ospf_area *area) +struct ospf_route *ospf_find_asbr_route_through_area(struct route_table *rtrs, struct prefix_ipv4 *asbr, struct ospf_area *area) { struct route_node *rn; @@ -320,8 +318,7 @@ int ospf_ase_calculate_route(struct ospf *ospf, struct ospf_lsa *lsa) if (rn == NULL || (asbr_route = rn->info) == NULL) { if (IS_DEBUG_OSPF(lsa, LSA)) - zlog_debug( - "Route[External]: Can't find route to forwarding address"); + zlog_debug("Route[External]: Can't find route to forwarding address"); if (rn) route_unlock_node(rn); return 0; @@ -443,8 +440,7 @@ int ospf_ase_calculate_route(struct ospf *ospf, struct ospf_lsa *lsa) zlog_debug("Route[External]: Routes are equal"); ospf_route_copy_nexthops(or, asbr_route->paths); if (al->e[0].fwd_addr.s_addr != INADDR_ANY) - ospf_ase_complete_direct_routes( - or, al->e[0].fwd_addr); + ospf_ase_complete_direct_routes(or, al->e[0].fwd_addr); } } /* Make sure setting newly calculated ASBR route.*/ @@ -533,8 +529,7 @@ static int ospf_ase_compare_tables(struct ospf *ospf, if ((or = rn->info)) { if (!(new_rn = route_node_lookup(new_external_route, &rn->p))) - ospf_zebra_delete( - ospf, (struct prefix_ipv4 *)&rn->p, or); + ospf_zebra_delete(ospf, (struct prefix_ipv4 *)&rn->p, or); else route_unlock_node(new_rn); } @@ -581,8 +576,7 @@ static void ospf_ase_calculate_timer(struct event *t) if (area->external_routing == OSPF_AREA_NSSA) LSDB_LOOP (NSSA_LSDB(area), rn, lsa) - ospf_ase_calculate_route(ospf, - lsa); + ospf_ase_calculate_route(ospf, lsa); } /* kevinm: And add the NSSA routes in ospf_top */ LSDB_LOOP (NSSA_LSDB(ospf), rn, lsa) From 0a2b1d3e96f186fa8ec302bc7f66493f75d229c4 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 12 Oct 2023 10:50:04 -0300 Subject: [PATCH 04/36] doc: long line --- ospfd/ospf_ase.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ospfd/ospf_ase.c b/ospfd/ospf_ase.c index 13b7b61c26..bd80fb32e7 100644 --- a/ospfd/ospf_ase.c +++ b/ospfd/ospf_ase.c @@ -75,10 +75,7 @@ struct ospf_route *ospf_find_asbr_route(struct ospf *ospf, best = or ; else if (best->cost == or->cost - && IPV4_ADDR_CMP( - &best->u.std.area_id, - & or->u.std.area_id) - < 0) + && IPV4_ADDR_CMP(&best->u.std.area_id,& or->u.std.area_id) < 0) best = or ; } From bb237d3c828ae844572998036ac494da6f9914a8 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 16 Oct 2023 10:36:34 -0300 Subject: [PATCH 05/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From b8562af7e4ea7c6b0828f6dc771118f59a1fdc76 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 6 Nov 2023 19:21:47 -0300 Subject: [PATCH 06/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 704f0701e9dd803a74a335b165d08ca61f178cfd Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 6 Nov 2023 19:49:26 -0300 Subject: [PATCH 07/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From 9e3ff7c06441f24aceb2d33580e0e66b3674dc31 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 6 Nov 2023 20:18:00 -0300 Subject: [PATCH 08/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 97eda270124af14f7cd73f97f640ccbc45a1ad14 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 6 Nov 2023 22:29:16 -0300 Subject: [PATCH 09/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From 386b8bd2037816fda98f2e8424851854fe59ab06 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Tue, 7 Nov 2023 07:46:06 -0300 Subject: [PATCH 10/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 9ef355b25f966c251075119e4e98410c50049c6f Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Tue, 7 Nov 2023 08:17:39 -0300 Subject: [PATCH 11/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From f49c31753bf013b77804b77827d5bc3efe7e2502 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Tue, 7 Nov 2023 08:18:49 -0300 Subject: [PATCH 12/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From b58258d755d900b7d2990c8ec0459033bdcc7748 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Tue, 7 Nov 2023 08:25:34 -0300 Subject: [PATCH 13/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From f2507e215c498ccab052ac243db29ad29000c752 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Tue, 7 Nov 2023 09:25:33 -0300 Subject: [PATCH 14/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 464b181d135abd843681a9b26cb1d95978ed945b Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Tue, 7 Nov 2023 10:02:01 -0300 Subject: [PATCH 15/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From f1d04b5462f140a53db4137c9610b16d2979bd4f Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Wed, 8 Nov 2023 08:03:29 -0300 Subject: [PATCH 16/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From b766e130b279346b0d9cd98675eee41c0495703d Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Wed, 8 Nov 2023 10:11:28 -0300 Subject: [PATCH 17/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From 46285910896fe470a5b7a3476003aec7da9ac53f Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Wed, 8 Nov 2023 10:17:23 -0300 Subject: [PATCH 18/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 3a1ffc1a426344fe86c6f945f6556d34963aaa5d Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Wed, 8 Nov 2023 12:14:52 -0300 Subject: [PATCH 19/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From ecdd1241e826f3be8863ced39ae678c5f6df9b85 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Wed, 8 Nov 2023 20:50:58 -0300 Subject: [PATCH 20/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 31482d24f131386842737ee00ac83d57a0f373ab Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 9 Nov 2023 11:16:22 -0300 Subject: [PATCH 21/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From fbeeedee3173233db68ed360e33ca03081ab369b Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 9 Nov 2023 19:14:23 -0300 Subject: [PATCH 22/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From c6cbd0e5b836022f976805a894b97314e842ab0b Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 9 Nov 2023 20:09:13 -0300 Subject: [PATCH 23/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From d7e991a16c2d8e1aca8a78209584ab1f035b6b86 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 9 Nov 2023 21:35:00 -0300 Subject: [PATCH 24/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From cdb1be5c01c26a78f290e7bdcce69a2615abfc01 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 9 Nov 2023 23:54:22 -0300 Subject: [PATCH 25/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From 109ff2e47634f20992c291aa4bfb64d2e18c3177 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Fri, 10 Nov 2023 07:45:10 -0300 Subject: [PATCH 26/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From adad4d6a817ed7ace059c967bf722078a288fa41 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 13 Nov 2023 18:04:21 -0300 Subject: [PATCH 27/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From 7b9a60fa82b83b6cbef606af99648d9c8ab7105d Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Tue, 21 Nov 2023 07:52:33 -0300 Subject: [PATCH 28/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From e74cb8a86e2211cfc35543168236c2dba083dd45 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 23 Nov 2023 16:19:37 -0300 Subject: [PATCH 29/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From d4d56657f35c4a10e997781b3cf98fd9767d276d Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Fri, 24 Nov 2023 11:24:11 -0300 Subject: [PATCH 30/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From d7ce1cb3fb202c01c0ead8ded89284409dc2d47c Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 14 Dec 2023 11:40:36 -0300 Subject: [PATCH 31/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From df07513f4e64d3e1f6c44ac50f823ab72cc06931 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Thu, 14 Dec 2023 16:10:43 -0300 Subject: [PATCH 32/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 1933e2a23d95eba8e39746fbbbe219b342b752e7 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 18 Dec 2023 08:09:26 -0300 Subject: [PATCH 33/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From 5d719ae4c2036f17b363d28a167c973fb8ee7c62 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 18 Dec 2023 08:22:08 -0300 Subject: [PATCH 34/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security -------- From 74d2f0af0378bae754db6ab152dbb003d50af73a Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Mon, 18 Dec 2023 08:29:36 -0300 Subject: [PATCH 35/36] doc: updating README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 600a91e386..a5febd45d2 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,6 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! - Security -------- From 259e4a944cca3ec229d427ab60e1988ffacb8ce3 Mon Sep 17 00:00:00 2001 From: Rodrigo Nardi Date: Fri, 22 Mar 2024 10:50:04 -0300 Subject: [PATCH 36/36] doc: updating README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a5febd45d2..600a91e386 100644 --- a/README.md +++ b/README.md @@ -72,6 +72,7 @@ internals is also available. We welcome and appreciate all contributions, no matter how small! + Security --------