Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade server core to v2 alpha3, remove scheduling and form dependencies #26

Merged
merged 7 commits into from
Mar 4, 2020
Merged

Upgrade server core to v2 alpha3, remove scheduling and form dependencies #26

merged 7 commits into from
Mar 4, 2020

Conversation

githengi
Copy link
Contributor

@githengi githengi commented Mar 4, 2020

Resolves #25

@githengi githengi requested review from manutarus, Rkareko and rkodev March 4, 2020 11:35
@coveralls
Copy link

coveralls commented Mar 4, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 126

  • 2 of 18 (11.11%) changed or added relevant lines in 7 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+4.04%) to 13.233%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/org/opensrp/connector/atomfeed/AllMarkersCouchImpl.java 0 1 0.0%
src/main/java/org/opensrp/connector/openmrs/service/HouseholdService.java 0 1 0.0%
src/main/java/org/opensrp/connector/dhis2/Dhis2HttpUtils.java 0 2 0.0%
src/main/java/org/opensrp/connector/openmrs/service/EncounterService.java 2 4 50.0%
src/main/java/org/opensrp/connector/openmrs/service/OpenmrsLocationService.java 0 2 0.0%
src/main/java/org/opensrp/connector/MultipartHttpUtil.java 0 3 0.0%
src/main/java/org/opensrp/connector/openmrs/service/PatientService.java 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/org/opensrp/connector/openmrs/service/EncounterService.java 2 36.68%
src/main/java/org/opensrp/connector/openmrs/constants/OpenmrsHouseHold.java 15 0%
Totals Coverage Status
Change from base Build 114: 4.04%
Covered Lines: 370
Relevant Lines: 2796
💛 - Coveralls

@githengi githengi force-pushed the upgrade-server-core-to-v2-alpha3 branch from 6a57c74 to 80dcd4d Compare March 4, 2020 14:04
@githengi githengi linked an issue Mar 4, 2020 that may be closed by this pull request
Upgrade OpenSRP core library to 2.0.0alpha3 and remove Motech dependency #25
Open
4 tasks
@githengi githengi merged commit 92681bd into spring-upgrade Mar 4, 2020
@githengi githengi deleted the upgrade-server-core-to-v2-alpha3 branch March 4, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkodev rkodev rkodev approved these changes

@manutarus manutarus Awaiting requested review from manutarus

@Rkareko Rkareko Awaiting requested review from Rkareko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade OpenSRP core library to 2.0.0alpha3 and remove Motech dependency
3 participants
@githengi @coveralls @rkodev