From 14222712a66bf1ee977af8bd6e6ef5e6ad02ea26 Mon Sep 17 00:00:00 2001
From: Daniel P <dpawlik@test.com>
Date: Wed, 12 Jun 2024 15:16:50 +0200
Subject: [PATCH] Fix OLM installation; remove repo_dir var; move operator-sdk
 to other dir

The ansible is failing when tasks responsible for olm are triggered.
Also changed a place for the binary: operator-sdk to better place (that
binary might be useful in the future).
---
 defaults/main.yaml |  5 -----
 tasks/olm.yaml     | 16 +++++-----------
 2 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/defaults/main.yaml b/defaults/main.yaml
index 16e9808..ea2ce07 100644
--- a/defaults/main.yaml
+++ b/defaults/main.yaml
@@ -98,11 +98,6 @@ setup_olm: false
 # https://github.com/operator-framework/operator-lifecycle-manager/releases
 olm_version: "v0.28.0"
 
-# Location where the additional projects should be keeped.
-# For example, if `setup_olm` is enabled, it will use Git to clone project
-# to that directory.
-repo_dir: "~{{ ansible_user }}/repos"
-
 # Version of the Operator SDK
 # https://github.com/operator-framework/operator-sdk/releases
 operator_sdk_version: "v1.34.2"
diff --git a/tasks/olm.yaml b/tasks/olm.yaml
index 8b81546..3abcfc7 100644
--- a/tasks/olm.yaml
+++ b/tasks/olm.yaml
@@ -1,22 +1,16 @@
 ---
-- name: Ensure installation directory
-  ansible.builtin.file:
-    path: "{{ repo_dir }}"
-    state: directory
-    mode: "0755"
-
 - name: Fetch operator-sdk
+  become: true
   ansible.builtin.uri:
     url: https://github.com/operator-framework/operator-sdk/releases/download/{{ operator_sdk_version }}/operator-sdk_linux_amd64
-    dest: "{{ repo_dir }}/operator-sdk"
+    dest: /usr/local/bin/operator-sdk
     mode: "755"
     status_code:
       - 200
       - 304
 
 - name: Check if OLM is installed
-  ansible.builtin.command:
-    "{{ repo_dir }}/operator-sdk olm status"
+  ansible.builtin.command: /usr/local/bin/operator-sdk olm status
   register: olm_status
   failed_when: olm_status.rc not in [0, 1]
   changed_when: true
@@ -32,7 +26,7 @@
     - "olm-operator-serviceaccount"
 
 - name: Install OLM with SDK
-  ansible.builtin.command:
-    "{{ repo_dir }}/operator-sdk olm install --version {{ olm_version }}"
+  ansible.builtin.command: |
+    /usr/local/bin/operator-sdk olm install --version {{ olm_version }}
   when: olm_status.rc != 0
   changed_when: true