Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uni02Beta] Install conntrack on EDPM nodes #395

Conversation

eduolivares
Copy link
Contributor

Some tobiko tests need the conntrack-tools package installed on the EDPM nodes.

Some tobiko tests need the conntrack-tools package installed on the EDPM
nodes.
@fultonj
Copy link
Contributor

fultonj commented Sep 11, 2024

+2 from me. Has it been tested downstream so we're safe to merge?

@eduolivares eduolivares added the needs-downstream-testing Requires downstream testing and verification before merging label Sep 11, 2024
@eduolivares
Copy link
Contributor Author

+2 from me. Has it been tested downstream so we're safe to merge?

let's wait until @gmarcian can test it downstream

@eduolivares eduolivares added testing-complete Testing is completed and ready for final reviews ready-review Request is ready to be reviewed needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges and removed needs-downstream-testing Requires downstream testing and verification before merging labels Sep 16, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, eduolivares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f05541ecb6784d43b81d835f19ee942a

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni02beta SUCCESS in 3m 28s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e6df7fd into openstack-k8s-operators:main Sep 16, 2024
7 checks passed
@eduolivares
Copy link
Contributor Author

/cherrypick 18.0.0-proposed

@openshift-cherrypick-robot

@eduolivares: new pull request created: #398

In response to this:

/cherrypick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

softwarefactory-project-zuul bot added a commit that referenced this pull request Sep 16, 2024
…95-to-18.0.0-proposed

[18.0.0-proposed] [Uni02Beta] Install conntrack on EDPM nodes

This is an automated cherry-pick of #395
/assign eduolivares

Reviewed-by: Andrew Bays <[email protected]>
@eduolivares eduolivares deleted the conntrack-to-unibeta branch September 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges ready-review Request is ready to be reviewed testing-complete Testing is completed and ready for final reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants