Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run fdb aging tests in single thread only #2347

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Run fdb aging tests in single thread only #2347

merged 1 commit into from
Sep 12, 2024

Conversation

m-blue-m
Copy link
Contributor

Otherwise job will fail.

@github-actions github-actions bot marked this pull request as draft September 12, 2024 17:51
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@m-blue-m m-blue-m marked this pull request as ready for review September 12, 2024 17:52
@rlandy
Copy link
Collaborator

rlandy commented Sep 12, 2024

Change looks ok to me - but would like to have test results to point to when approving. thank you

@rlandy
Copy link
Collaborator

rlandy commented Sep 12, 2024

@m-blue-m thanks for referencing the recent failure and for comments:
".. the testing code there is meant to run only with single thread jobs,...
It was verified on similar setup manually beforehand and other devstack jobs."

@rlandy
Copy link
Collaborator

rlandy commented Sep 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 12, 2024
@ralonsoh
Copy link

/lgtm

@raukadah
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9ce85a9 into openstack-k8s-operators:main Sep 12, 2024
6 checks passed
@viroel viroel mentioned this pull request Sep 14, 2024
Merged
viroel added a commit that referenced this pull request Sep 16, 2024
@viroel
Exclude neutron whitebox test_ovn_fdb tests
cba3087 
test_ovn_fdb test is failing and required a fix in the plugin.
Moving it to single thread test also didn't work[1], so the best
is to remove it from multi-thread test list.

[1] #2347
@viroel viroel mentioned this pull request Sep 16, 2024
Merged
viroel added a commit that referenced this pull request Sep 16, 2024
@viroel
Exclude neutron whitebox test_ovn_fdb tests
690d138 
test_ovn_fdb test is failing and required a fix in the plugin.
Moving it to single thread test also didn't work[1], so the best
is to remove it from multi-thread test list.

[1] #2347
openshift-merge-bot bot pushed a commit that referenced this pull request Sep 16, 2024
@viroel @openshift-merge-bot
Exclude neutron whitebox test_ovn_fdb tests
716da14 
test_ovn_fdb test is failing and required a fix in the plugin.
Moving it to single thread test also didn't work[1], so the best
is to remove it from multi-thread test list.

[1] #2347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rlandy rlandy

@ralonsoh ralonsoh

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-blue-m @rlandy @ralonsoh @raukadah