-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry to cephadm install #2633
Add retry to cephadm install #2633
Conversation
Thanks for the PR! ❤️ |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6221678ae10f4fb4b10e1721f3b603f4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 43s |
recheck |
@@ -30,6 +30,10 @@ | |||
ansible.builtin.dnf: | |||
name: cephadm | |||
state: present | |||
register: task_result | |||
retries: 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe not important, just out of curiosity: how did we come up w/ these numbers? is there any best practice to set defaults? Would it be good to define two variables under roles/cifmw_cephadm/default/main.yaml
with those numbers, so we can eventually pass them as overrides to the jobs?
Apart from this small potential change, I'm not against this patch and we can land it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good point. I've just added the default values.
7004dca
to
8325068
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
8325068
to
545a801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
88bd379
into
openstack-k8s-operators:main
/cherry-pick 18.0-fr1 |
@jirimacku: #2633 failed to apply on top of branch "18.0-fr1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The cephadm package install is failing occasionally because of repo temporary issues. Let's add retries.