Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to cephadm install #2633

Conversation

jirimacku
Copy link
Contributor

@jirimacku jirimacku commented Jan 8, 2025

The cephadm package install is failing occasionally because of repo temporary issues. Let's add retries.

@jirimacku jirimacku requested a review from a team as a code owner January 8, 2025 10:51
@github-actions github-actions bot marked this pull request as draft January 8, 2025 10:51
Copy link

github-actions bot commented Jan 8, 2025

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@jirimacku jirimacku marked this pull request as ready for review January 8, 2025 10:59
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6221678ae10f4fb4b10e1721f3b603f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 29s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 49s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 41m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 42s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 57s
✔️ build-push-container-cifmw-client SUCCESS in 36m 16s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 5m 09s

@jirimacku
Copy link
Contributor Author

recheck

@@ -30,6 +30,10 @@
ansible.builtin.dnf:
name: cephadm
state: present
register: task_result
retries: 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not important, just out of curiosity: how did we come up w/ these numbers? is there any best practice to set defaults? Would it be good to define two variables under roles/cifmw_cephadm/default/main.yaml with those numbers, so we can eventually pass them as overrides to the jobs?
Apart from this small potential change, I'm not against this patch and we can land it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good point. I've just added the default values.

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 88bd379 into openstack-k8s-operators:main Jan 9, 2025
3 of 4 checks passed
@jirimacku
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@jirimacku: #2633 failed to apply on top of branch "18.0-fr1":

Applying: Add retry to cephadm install
Using index info to reconstruct a base tree...
M	roles/cifmw_cephadm/defaults/main.yml
A	roles/cifmw_cephadm/tasks/install_cephadm.yml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): roles/cifmw_cephadm/tasks/install_cephadm.yml deleted in HEAD and modified in Add retry to cephadm install. Version Add retry to cephadm install of roles/cifmw_cephadm/tasks/install_cephadm.yml left in tree.
Auto-merging roles/cifmw_cephadm/defaults/main.yml
CONFLICT (content): Merge conflict in roles/cifmw_cephadm/defaults/main.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add retry to cephadm install

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants