Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0-fr1] Add the hypervisors to the inventory #2645

Open
wants to merge 1 commit into
base: 18.0-fr1
Choose a base branch
from
Open

[18.0-fr1] Add the hypervisors to the inventory #2645

wants to merge 1 commit into from
+16 −0

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2620

/assign eurijon

@pablintino
Add the hypervisors to the inventory
a68a5d8 
For use cases like ShiftOnStack the deployment may need to tweak the
hypervisor.
We did not have a way to tell the deployment how to reach the hypervisor
so this commit exposes the hypervisor Ansible instance to each host
and creates a hypervisors group in the generated inventory.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 14, 2025
Merged
@github-actions github-actions bot marked this pull request as draft January 14, 2025 08:47
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@pablintino pablintino marked this pull request as ready for review January 14, 2025 08:47
@pablintino
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9e799f4e391b4217b3283bb9a7b7271c

❌ openstack-k8s-operators-content-provider FAILURE in 15m 08s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 40s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 03s
✔️ build-push-container-cifmw-client SUCCESS in 36m 47s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 44m 21s
✔️ cifmw-molecule-reproducer SUCCESS in 17m 17s

@pablintino
Copy link
Collaborator

recheck

ciecierski
ciecierski requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ciecierski ciecierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comment: #2620 (comment)

@pablintino
Copy link
Collaborator

Hi @ciecierski, it's ok for you if we merge this now that the patch to avoid the issue in DS is merged?

ciecierski
ciecierski approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ciecierski ciecierski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to merge. Problem was in internal ansible playbook logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciecierski ciecierski ciecierski approved these changes

Assignees

@eurijon eurijon

@pablintino pablintino

Labels
approved do-not-merge/hold lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @pablintino @ciecierski @eurijon