Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default RGW realm before rendering the spec #2681

Closed
wants to merge 1 commit into from

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Jan 27, 2025

With Ceph Squid RGW fails to deploy because the default realm is missing [1].
In particular it fails with the following error:

0 rgw main: failed to load realm: (2) No such file or directory
 -1 Couldn't init storage provider (RADOS)

that is clearly referred to a missing default realm.
This used to work well (probably because of a Ceph default) but it started failing from Ceph Squid+ .
This patch creates a default realm beforehand, and it is valid both for Squid and previous releases.

[1] https://tracker.ceph.com/issues/69676

Jira: https://issues.redhat.com/browse/OSPRH-10666

@fmount fmount requested a review from a team as a code owner January 27, 2025 07:47
@fmount fmount requested a review from tosky January 27, 2025 07:47
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70f91fa08ac64f3b934ed594c5ad59ff

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 25s
podified-multinode-edpm-deployment-crc FAILURE in 17m 10s
cifmw-crc-podified-edpm-baremetal FAILURE in 22m 04s
podified-multinode-hci-deployment-crc FAILURE in 21m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 09s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 25s
✔️ build-push-container-cifmw-client SUCCESS in 17m 33s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 5m 46s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d1df6c58355948ada8d49bbb54aa9bf6

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 15s
podified-multinode-edpm-deployment-crc FAILURE in 1h 23m 30s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 20m 53s
podified-multinode-hci-deployment-crc FAILURE in 57m 58s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 00s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 28s
✔️ build-push-container-cifmw-client SUCCESS in 17m 22s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 26s

roles/cifmw_cephadm/tasks/rgw.yml Outdated Show resolved Hide resolved
- name: Create default RGW realm
when: rgw_realm.rc > 0
ansible.builtin.command: |
{{ cifmw_cephadm_ceph_cli }} realm create --rgw-realm={{ cifmw_ceph_rgw_realm }}
Copy link

@ASBishop ASBishop Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about this area , but when I googled I see there's a "--default" option you can specify, and it's unclear whether the option is relevant when there are multiple realms or just one. I'm only noting it in case it warrants investigation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I can try that option and see if anything change (or allows to write less code :D).
From a test I did on an existing Ceph cluster, I saw that realm was an empty list, and considering we do not deploy rgw multi site in CI, my idea was to create in advance a default realm that can match what we already have in the previous versions. It's a parameter, in case we would like to have a better name rather than "default".

@fmount fmount force-pushed the rgw_realm branch 3 times, most recently from 92bd243 to e39efc3 Compare January 27, 2025 15:10
With Ceph Squid RGW fails to deploy because the default realm is
missing. In particular it fails with the following error:

'''
0 rgw main: failed to load realm: (2) No such file or directory
-1 Couldn't init storage provider (RADOS)
'''

that is clearly referred to a missing default realm.
This used to work well (probably because of a Ceph default) but
it started failing from Ceph Squid+ (RHCS 8).
This patch creates a default realm beforehand, and it is valid
both with RHCS 8 and previous releases.

Jira: https://issues.redhat.com/browse/OSPRH-10666

Signed-off-by: Francesco Pantano <[email protected]>
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/acbeceedf74543b495f5ce99822b2659

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 26s
podified-multinode-edpm-deployment-crc FAILURE in 1h 24m 11s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 27m 46s
podified-multinode-hci-deployment-crc POST_FAILURE in 1h 33m 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 10s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 41s
✔️ build-push-container-cifmw-client SUCCESS in 17m 36s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 24s

@fmount
Copy link
Contributor Author

fmount commented Jan 29, 2025

Closing in favor of #2687 that is easier and results in less complexity we need to maintain.

@fmount fmount closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants