-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create default RGW realm before rendering the spec #2681
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70f91fa08ac64f3b934ed594c5ad59ff ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 25s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d1df6c58355948ada8d49bbb54aa9bf6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 15s |
- name: Create default RGW realm | ||
when: rgw_realm.rc > 0 | ||
ansible.builtin.command: | | ||
{{ cifmw_cephadm_ceph_cli }} realm create --rgw-realm={{ cifmw_ceph_rgw_realm }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know nothing about this area , but when I googled I see there's a "--default" option you can specify, and it's unclear whether the option is relevant when there are multiple realms or just one. I'm only noting it in case it warrants investigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I can try that option and see if anything change (or allows to write less code :D).
From a test I did on an existing Ceph
cluster, I saw that realm
was an empty list, and considering we do not deploy rgw multi site in CI, my idea was to create in advance a default
realm that can match what we already have in the previous versions. It's a parameter, in case we would like to have a better name rather than "default".
92bd243
to
e39efc3
Compare
With Ceph Squid RGW fails to deploy because the default realm is missing. In particular it fails with the following error: ''' 0 rgw main: failed to load realm: (2) No such file or directory -1 Couldn't init storage provider (RADOS) ''' that is clearly referred to a missing default realm. This used to work well (probably because of a Ceph default) but it started failing from Ceph Squid+ (RHCS 8). This patch creates a default realm beforehand, and it is valid both with RHCS 8 and previous releases. Jira: https://issues.redhat.com/browse/OSPRH-10666 Signed-off-by: Francesco Pantano <[email protected]>
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/acbeceedf74543b495f5ce99822b2659 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 26s |
Closing in favor of #2687 that is easier and results in less complexity we need to maintain. |
With Ceph
Squid
RGW
fails to deploy because the defaultrealm
is missing [1].In particular it fails with the following error:
that is clearly referred to a missing default realm.
This used to work well (probably because of a
Ceph
default) but it started failing from CephSquid+
.This patch creates a default realm beforehand, and it is valid both for
Squid
and previous releases.[1] https://tracker.ceph.com/issues/69676
Jira: https://issues.redhat.com/browse/OSPRH-10666