From 60607575ecfde7c2c17e2c159108542b9627314c Mon Sep 17 00:00:00 2001 From: rabi Date: Thu, 30 Nov 2023 14:17:05 +0530 Subject: [PATCH] Always reset SetupReadyCondition to False We use this condition to trigger deployments for a nodeset. Without this being reset to false, deployments would tigger before nodeset is reconciled for update/patch as the condition would be true. --- controllers/openstackdataplanenodeset_controller.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/controllers/openstackdataplanenodeset_controller.go b/controllers/openstackdataplanenodeset_controller.go index 97c54183e..688013e4b 100644 --- a/controllers/openstackdataplanenodeset_controller.go +++ b/controllers/openstackdataplanenodeset_controller.go @@ -183,9 +183,7 @@ func (r *OpenStackDataPlaneNodeSetReconciler) Reconcile(ctx context.Context, req return ctrl.Result{}, nil } - if instance.Status.Conditions.IsUnknown(dataplanev1.SetupReadyCondition) { - instance.Status.Conditions.MarkFalse(dataplanev1.SetupReadyCondition, condition.RequestedReason, condition.SeverityInfo, condition.ReadyInitMessage) - } + instance.Status.Conditions.MarkFalse(dataplanev1.SetupReadyCondition, condition.RequestedReason, condition.SeverityInfo, condition.ReadyInitMessage) // Ensure Services err = deployment.EnsureServices(ctx, helper, instance)