From fb21c47842e012a5a8ac7f9adb0960cb22f8a893 Mon Sep 17 00:00:00 2001
From: Martin Schuppert <mschuppert@redhat.com>
Date: Fri, 13 Dec 2024 11:25:49 +0100
Subject: [PATCH] [conditions] Reset conditions on Init()

Recently the operators changed to use CreateServiceReadyCondition
instead of ExposeServiceReadyCondition. An update of an existing
environment would result in the ExposeServiceReadyCondition to be
never removed from the conditions list of a CR because the list
is not reset on Init().

This adds a Reset() method and a call right at the start of Init().

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
---
 modules/common/condition/funcs.go      |  6 +++++
 modules/common/condition/funcs_test.go | 37 +++++++++++++++++++++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/modules/common/condition/funcs.go b/modules/common/condition/funcs.go
index 68146601..ecfb31a7 100644
--- a/modules/common/condition/funcs.go
+++ b/modules/common/condition/funcs.go
@@ -34,6 +34,7 @@ import (
 // Optional conditions list can be passed as parameter which allows to initialize
 // additional conditions at the beginning.
 func (conditions *Conditions) Init(cl *Conditions) {
+	conditions.Reset()
 	conditions.Set(UnknownCondition(ReadyCondition, RequestedReason, ReadyInitMessage))
 
 	// add all optional conditions if no not nil
@@ -102,6 +103,11 @@ func (conditions *Conditions) Remove(t Type) {
 	*conditions = newConditions
 }
 
+// Reset - removes all conditions
+func (conditions *Conditions) Reset() {
+	*conditions = Conditions{}
+}
+
 // Get returns the condition with the given type, if the condition does not exists,
 // it returns nil.
 func (conditions *Conditions) Get(t Type) *Condition {
diff --git a/modules/common/condition/funcs_test.go b/modules/common/condition/funcs_test.go
index 56aabe2c..88d60556 100644
--- a/modules/common/condition/funcs_test.go
+++ b/modules/common/condition/funcs_test.go
@@ -83,7 +83,10 @@ func TestInit(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			g := NewWithT(t)
 
-			conditions := Conditions{}
+			someCondition := TrueCondition("foo", "to be removed on Init()")
+			conditions := Conditions{
+				*someCondition,
+			}
 
 			conditions.Init(&tt.conditions)
 			g.Expect(conditions).To(haveSameConditionsOf(tt.want))
@@ -228,6 +231,38 @@ func TestRemove(t *testing.T) {
 	}
 }
 
+func TestReset(t *testing.T) {
+	tests := []struct {
+		name       string
+		conditions Conditions
+		expected   Conditions
+	}{
+		{
+			name:       "empty",
+			conditions: Conditions{},
+			expected:   Conditions{},
+		},
+		{
+			name: "present",
+			conditions: CreateList(
+				unknownReady,
+				unknownA,
+				unknownB,
+			),
+			expected: Conditions{},
+		},
+	}
+
+	g := NewWithT(t)
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			tt.conditions.Reset()
+			g.Expect(tt.expected).To(haveSameConditionsOf(tt.conditions))
+		})
+	}
+}
+
 func TestHasSameState(t *testing.T) {
 	g := NewWithT(t)