Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when accidentally saving just lines, etc. #10471

Closed
jidanni opened this issue Sep 21, 2024 · 6 comments · Fixed by #10706
Closed

Warn when accidentally saving just lines, etc. #10471

jidanni opened this issue Sep 21, 2024 · 6 comments · Fixed by #10706
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome!

Comments

@jidanni
Copy link
Contributor

jidanni commented Sep 21, 2024

Description

Find some road,

  • highway=unclassified
  • oneway=no

and remove the

  • highway=unclassified

tag by accident, and save your changes.

No warning is given that all there is is a "line" left on the map.

@k-yle
Copy link
Collaborator

k-yle commented Jan 14, 2025

This would be trivial to implement, oneway just needs to be added to onlyAttributeKeys:

var onlyAttributeKeys = ['description', 'name', 'note', 'start_date'];

@k-yle k-yle added the new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome! label Jan 14, 2025
@pamnanaimanish169

This comment has been minimized.

@k-yle

This comment has been minimized.

@Avan2021

This comment has been minimized.

@k-yle

This comment has been minimized.

@Avan2021
Copy link
Contributor

Avan2021 commented Jan 24, 2025

Hi @k-yle , please review the PR #10706 for this issue and let me know if you want me to make any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new contributor opportunity Best for first-time contributors without prior experience. You won’t be assigned; PRs welcome!
Projects
None yet
4 participants