Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossing: When switching to crossing=unmarked, remove crossing:markings=zebra etc #1283

Open
tordans opened this issue Jul 12, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@tordans
Copy link
Collaborator

tordans commented Jul 12, 2024

This is just a stub for now. I just noticed the tagging was not removed. We should check this after the crossing refactoring was merged. Not sure if there is a good way to build this, since not all tags should be removed, just some values.

@tordans tordans added the bug Something isn't working label Jul 12, 2024
@k-yle
Copy link
Collaborator

k-yle commented Jul 13, 2024

@tordans this is possible using removeTags, for example:

"removeTags": {
"highway": "construction",
"access": "no",
"construction": "*"
},

@tordans
Copy link
Collaborator Author

tordans commented Jul 13, 2024

@k-yle right, but I was wondering if we really want to remove all tags or just some, when "leaving" the preset. But I guess once the tag is removed the next presets addTags will re-add the right tag, so that will likely be fine.

Personally I will wait for #1201 to be merged to have a clean slate on alls things crossing.

https://github.com/ideditor/schema-builder?tab=readme-ov-file#removetags

@1ec5
Copy link
Contributor

1ec5 commented Jul 14, 2024

I assume this is actually about overwriting crossing:markings=* with crossing:markings=no? Otherwise, it would immediately trigger a validator warning about incomplete tagging.

Also, for consideration: crossing:markings=surface answers the question, “Are there painted markings?” with, “Well, not really, but there is a surface treatment.” In some jurisdictions, a surface treatment isn’t legally considered a marking, and there’s still debate among specialists about whether they’re more or less visible than standard markings.

The crossing:markings=* proposal included this value with the understanding that some laypeople wouldn’t know that, pedantically, it doesn’t count as an unmarked crossing, so at least it should be recorded somehow. The Unmarked Crossing preset doesn’t include a field for this tag, but I suspect we should preserve it given the lack of real-world clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants