iD incorrectly deletes the building= tag when applying preset of various amenity types

[deevroman]

How to reproduce the issue?

1. Select a building
2. Apply the Morgue preset, for example
3. The building=* tag has been removed

bug_id.mp4

This also happens with presets for hospitals, schools, etc. Some will say that these presets imply a territory and therefore remove building=. But I believe that iD should not clean up building=:

1. building= + amenity= acceptable tagging
2. iD doesn't remove additional building tags:

bug_id2.mp4

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

No response

[Deeptanshu-sankhwar]

Thanks for sharing this issue @deevroman. I have reproduced this issue, and I also see that this happens not just for building, but I believe for everything else as well. If we select a road, restaurant etc, and changes its preset, some of the initial tags are removed.

Here is an example below

[tyrasd]

In principle this is working as designed: The tags of the previous preset are removed from the feature and the tags from the new preset are applied to it. This is to allow changing features between different types, e.g. from natural=wood to landuse=forest. There is however also a mechanism which allows to keep (some) of the previous tags in a preset change: If the new preset has a field for the tag of the previous preset, the tag is kept. This is for example used in the building preset.

That said, this would be solved by adding a field for the building tag to the Morgue preset (and potentially also the Hospital preset¹).

Footnotes

1. See also the OSM wiki: “Note that the buildings should not carry the amenity=hospital tag.” ↩

[DujaOSM]

1. See also the OSM wiki: _“Note that the buildings should not carry the `amenity=hospital` tag.”

Duly tagged as {{questionable}} en route to deletion. According to taginfo, there are 20,000 out of 200,000 hospitals worldwide doubly-tagged as building=*.

I also think that building=* is an ancillary tag that can be applied to pretty much any amenity or shop, so it should not be deleted by applying a preset. I'm not sure if the schema distinguishes applying presets to point elements (in which case, building=* should probably be removed) from areas (where the existing building=* should be preserved).

[Hufkratzer]

Maybe it can be solved this way: If someone selects a building and tries to add an amenity (or other feature) tag for which the preset does not have a building field, then instead of deleting the building tag add a new node in the middle of or near the building, apply the new preset there and select this new node instead of the building. Perhaps ask/warn before doing it like that.