Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved names and cleaned up main.gd #122

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Moved names and cleaned up main.gd #122

merged 3 commits into from
Oct 19, 2020

Conversation

TheSecondReal0
Copy link
Member

Moved the name system into network.gd and generally cleaned up main.gd. I removed a lot of unnecessary networking stuff from main, and created a new signal that network.gd emits when a player connection is done being handled. Consolidation of network stuff isn't complete with this, so don't close #98.

monban
monban approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@monban monban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that when the server transitions to the game map (test) the client stays in the lobby (though they can still see each other). I think this existed prior to this PR, so I'm going to approve it and put in a bug that we can fix.

@TheSecondReal0 TheSecondReal0 merged commit 8aac3f7 into opensuspect:main Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monban monban monban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate networking stuff into network.gd
2 participants
@TheSecondReal0 @monban