Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct null assertions when deserializing #211

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Nov 19, 2024

previously this would throw null pointer exception if "assertions": null was in the manifest, this should stop that error and assign assertions and empty arraylist if it is null on deserialization

@elizabethhealy elizabethhealy changed the title fix: Check for null manifest assertions before iterating fix: Correct null assertions when deserializing Nov 20, 2024
@elizabethhealy elizabethhealy marked this pull request as ready for review November 20, 2024 17:02
@elizabethhealy elizabethhealy requested review from a team as code owners November 20, 2024 17:02
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@elizabethhealy elizabethhealy merged commit b075194 into main Nov 21, 2024
6 of 7 checks passed
@elizabethhealy elizabethhealy deleted the check-null-manifest-assertions branch November 21, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants