Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: pipeline should skip most tests if only updates were .md files #1510

Open
jakedoublev opened this issue Sep 4, 2024 · 1 comment · Fixed by #1587 or #1666
Open

CI: pipeline should skip most tests if only updates were .md files #1510

jakedoublev opened this issue Sep 4, 2024 · 1 comment · Fixed by #1587 or #1666
Assignees
@elizabethhealy
Labels
comp:ci Github Actions Work

Comments

@jakedoublev
Copy link
Contributor

Background

The pipeline currently runs Go tests on every module, integration tests, xtests, build tests, etc if any files were changed. However, changes to documentation alone should not trigger these tests.

Acceptance Criteria

  1. add a paths-ignore directive to the checks.yaml to skip **.*.md
@jakedoublev jakedoublev added the comp:ci Github Actions Work label Sep 4, 2024
@jakedoublev
Copy link
Contributor Author

jakedoublev commented Sep 4, 2024 •
edited
Loading

related to #1508

@elizabethhealy elizabethhealy self-assigned this Sep 30, 2024
@elizabethhealy elizabethhealy mentioned this issue Sep 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
@elizabethhealy
fix(ci): Don't run tests for markdown changes (#1587)
8ffa32d 
resolves #1510
This was referenced Oct 17, 2024
Draft
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
@elizabethhealy @jakedoublev
fix(ci): Revert "Don't run tests for markdown changes" (#1666)
0288e76 
Reverts #1587
resolves #1510

Co-authored-by: Jake Van Vorhis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elizabethhealy elizabethhealy

Labels
comp:ci Github Actions Work
Projects
None yet
Milestone
No milestone
2 participants
@elizabethhealy @jakedoublev