From 61a872937d027d0a91c102e6b625682bbade9b12 Mon Sep 17 00:00:00 2001 From: Sean Trantalis Date: Sat, 9 Nov 2024 19:55:56 -0500 Subject: [PATCH 1/2] fix: set defatult mimeType in tdf manifest --- lib/tdf3/src/tdf.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/tdf3/src/tdf.ts b/lib/tdf3/src/tdf.ts index 699c2633..3c8cc23b 100644 --- a/lib/tdf3/src/tdf.ts +++ b/lib/tdf3/src/tdf.ts @@ -68,6 +68,7 @@ import { SymmetricCipher } from './ciphers/symmetric-cipher-base.js'; // TODO: input validation on manifest JSON const DEFAULT_SEGMENT_SIZE = 1024 * 1024; +const DEFAULT_MIME_TYPE = 'application/octet-stream'; /** * Configuration for TDF3 @@ -445,7 +446,7 @@ async function _generateManifest( protocol: 'zip', isEncrypted: true, schemaVersion: '3.0.0', - ...(mimeType && { mimeType }), + mimeType: mimeType || DEFAULT_MIME_TYPE, }; const encryptionInformationStr = await encryptionInformation.write(policy, keyInfo); From 819241dcb89b31c28dd92e7349d104fb06589b45 Mon Sep 17 00:00:00 2001 From: Sean Trantalis Date: Sat, 9 Nov 2024 20:33:24 -0500 Subject: [PATCH 2/2] set default param instead --- lib/tdf3/src/tdf.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/tdf3/src/tdf.ts b/lib/tdf3/src/tdf.ts index 3c8cc23b..6654cf72 100644 --- a/lib/tdf3/src/tdf.ts +++ b/lib/tdf3/src/tdf.ts @@ -437,7 +437,7 @@ async function _generateManifest( keyInfo: KeyInfo, encryptionInformation: SplitKey, policy: Policy, - mimeType: string | undefined + mimeType: string = DEFAULT_MIME_TYPE ): Promise { // (maybe) Fields are quoted to avoid renaming const payload = { @@ -446,7 +446,7 @@ async function _generateManifest( protocol: 'zip', isEncrypted: true, schemaVersion: '3.0.0', - mimeType: mimeType || DEFAULT_MIME_TYPE, + mimeType: mimeType, }; const encryptionInformationStr = await encryptionInformation.write(policy, keyInfo);