You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
remote_ip - the IP of the client, example: {151, 236, 219, 228}. This field is meant to be overwritten by plugs that understand e.g. the X-Forwarded-For header or HAProxy's PROXY protocol. It defaults to peer's IP
If conn.remote_ip has the apparent client IP address from X-Forwarded-For, that should go in http.client_ip, which you did by other means, not in net.host.ip. So there'll be some cleaning up in there.
The text was updated successfully, but these errors were encountered:
I've raised elixir-plug/plug#948 to see if we can get the sock out of conn.adapter via official means rather than rummaging, matching the use of Plug.Conn.get_peer_data/1 in #4.
Aah, I get it now. "host" != "server". For spans sent by an HTTP client, the HTTP client is the host and the HTTP server is the peer. For spans sent by an HTTP server, the HTTP client is the peer and the HTTP server is the host.
lib/opentelemetry_plug.ex
reads wrong to me:vs the semantic conventions spec:
… and the semantic conventions for HTTP spec, from which I lack the time to extract the right bit, and
Plug.Conn
:If
conn.remote_ip
has the apparent client IP address from X-Forwarded-For, that should go inhttp.client_ip
, which you did by other means, not innet.host.ip
. So there'll be some cleaning up in there.The text was updated successfully, but these errors were encountered: