Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding network interface control over REST API in the implementation of a joiner REST API #2627

Open
OmegaRelay opened this issue Nov 28, 2024 · 3 comments

Comments

@OmegaRelay
Copy link

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is.

Hello, I would like to expand the current REST API by adding an interface to control the border router's joiner to securely join a new network. However, this requires the network interface to be up and the thread protocol to be disabled. As far as I can tell it is not currently possible to control these two independent of each other through the current REST API.

Describe the solution you'd like A clear and concise description of what you want to happen.

  • Am I missing something; is it possible to control the network interface independently via the REST API?
  • Advice on the most preferable way to facilitate this.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

The solutions I can think of are:

  • Add another endpoint /node/iface, /node/interface, or /node/network which accepts PUT and GET requests to set the interface up/down or to get the interface state respectively.
  • A PUT request on the new /node/joiner/state endpoint to start the joiner, will automatically set the network interface up if not already.

I'm open to alternative solutions.

Additional context Add any other context or screenshots about the feature request here.

@wgtdkp
Copy link
Member

wgtdkp commented Nov 28, 2024

Hello, I would like to expand the current REST API by adding an interface to control the border router's joiner to securely join a new network.

I don't get it, could you provide more context about what you want to support?

@theisHafele
Copy link

Hi @wgtdkp I want to support being able to join a new border router to a pre-existing network (without having to manually provide the dataset), through the commissioning protocol using the REST API. Basically bringing the ot-ctl functionality of joiner start <pskd> into the REST interface.

@wgtdkp
Copy link
Member

wgtdkp commented Nov 29, 2024

Hi @wgtdkp I want to support being able to join a new border router to a pre-existing network (without having to manually provide the dataset), through the commissioning protocol using the REST API. Basically bringing the ot-ctl functionality of joiner start <pskd> into the REST interface.

Thanks for the info, I got it!

A PUT request on the new /node/joiner/state endpoint to start the joiner, will automatically set the network interface up if not already.

This looks more reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants