Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to upstream cose-c #70

Open
gocarlos opened this issue Apr 15, 2020 · 2 comments
Open

update to upstream cose-c #70

gocarlos opened this issue Apr 15, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@gocarlos
Copy link
Contributor

gocarlos commented Apr 15, 2020

I was been doing some changes to cose-c e.g. putting headers in namespace e.g. cose/cose.h, adding namespaced targets e.g. cose-c::cose-c and improving the cmake files...

this means, there are some breaking changes for ot-commissioner, though the effort should be pretty small.

@wgtdkp wgtdkp added the enhancement New feature or request label Apr 16, 2020
@wgtdkp wgtdkp self-assigned this Apr 16, 2020
@wgtdkp
Copy link
Member

wgtdkp commented Apr 16, 2020

@gocarlos Thanks for your contribution! Currently cose-c branch OT Commissioner is depending on has some additional API, for example:
https://github.com/wgtdkp/COSE-C/blob/059e8f4dbe9827ed89f6731e95052a5a1b79ed94/include/cose.h#L335

But those changes haven't been merged back to the COSE-C master branch, see the PR.

@gocarlos
Copy link
Contributor Author

upstream seems to compile again after applying cose-wg/COSE-C#93 to current COSE-C master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants