Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Crash After PR #2937 #2939

Closed
2 of 5 tasks
Solkrasm opened this issue Oct 4, 2024 · 2 comments · Fixed by #2926
Closed
2 of 5 tasks

Windows Crash After PR #2937 #2939

Solkrasm opened this issue Oct 4, 2024 · 2 comments · Fixed by #2926
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Solkrasm
Copy link

Solkrasm commented Oct 4, 2024 •
edited
Loading

Priority

Critical

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

#2937

Server Crashs when try to log-in game. @dudantas

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Solkrasm Solkrasm added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 4, 2024
@github-actions github-actions bot added Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing labels Oct 4, 2024
@libergod
Copy link

libergod commented Oct 4, 2024 •
edited
Loading

In a Linux environment, the game screen keeps trying to connect after the char selects forever.

image
image

@dudantas dudantas mentioned this issue Oct 5, 2024
Merged
@dudantas
Copy link
Contributor

dudantas commented Oct 5, 2024 •
edited
Loading

Fixed here: #2926

The crash started to occur after the network message pull request (#2914), and only with the log trace enabled.

@dudantas dudantas closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Critical Represents a risk to live servers Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: debug build from solution and improve NetworkMessage::add function opentibiabr/canary
3 participants
@dudantas @libergod @Solkrasm