Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git integration - ots-git-gpg-wrapper.sh instructions #64

Open
omarshibli opened this issue Sep 28, 2017 · 2 comments · May be fixed by #121
Open

Git integration - ots-git-gpg-wrapper.sh instructions #64

omarshibli opened this issue Sep 28, 2017 · 2 comments · May be fixed by #121

Comments

@omarshibli
Copy link

omarshibli commented Sep 28, 2017 •
edited
Loading

it's not well documented in the git integration document that ots-git-gpg-wrapper.sh should be installed from https://raw.githubusercontent.com/opentimestamps/opentimestamps-client/master/ots-git-gpg-wrapper.sh

I think it would be easier to follow if the url is explicitly mentioned in the instructions.
Something like this would be helpful and save some time:

cd ~
wget https://raw.githubusercontent.com/opentimestamps/opentimestamps-client/master/ots-git-gpg-wrapper.sh
git config --global gpg.program ~/ots-git-gpg-wrapper.sh
@petertodd
Copy link
Member

Hmm, that's an interesting point!

Though I don't feel comfortable telling users to use wget or the like to download dependencies off the web. Since the wrapper script is so short - just a single line - maybe the thing to do is just put it in the docs itself and tell users how to create it?

@omarshibli
Copy link
Author

good idea, let me prepare a PR and let me know what do you think.

@omarshibli omarshibli mentioned this issue Oct 21, 2017
Open
@nobodyinperson nobodyinperson linked a pull request Sep 28, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petertodd @omarshibli