Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contain whole video in SubscriberView (vs. zoom to fit) #472

Closed
deermichel opened this issue Feb 15, 2021 · 3 comments
Closed

Contain whole video in SubscriberView (vs. zoom to fit) #472

deermichel opened this issue Feb 15, 2021 · 3 comments

Comments

@deermichel
Copy link
Contributor

Is there a way to set the SubscriberView's display mode to contain the whole video (potentially with black bars) rather than zoom it to cover the view area? Currently, we loose content at the edges of the video when publishing a 3:4 stream to a 9:16 subscriber (we use fullscreen views in our application, this is a problem especially when mixing portrait & landscape streams). If this behaviour cannot be achieved by the library itself, is there a simple flag in the native SDKs which can be passed through? Thanks 🎉
@deermichel
Copy link
Contributor Author

Ok, i figured out that the native SDKs for iOS and Android offer a property to change the view scale behavior. I'll try to create a PR with the property passed through to the RN components.

@deermichel
Copy link
Contributor Author

PR is up: #474.

@tahagates97
Copy link

Hey @deermichel I'm facing exact issue on title rn. Can you provide more information about this idk what is PR and how to use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deermichel @tahagates97