Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure warnings found and -Werror specified #9

Open
SyCode7 opened this issue Apr 2, 2020 · 4 comments
Open

Compilation failure warnings found and -Werror specified #9

SyCode7 opened this issue Apr 2, 2020 · 4 comments

Comments

@SyCode7
Copy link

SyCode7 commented Apr 2, 2020

I tried to compile after cloning the repository.
mvn package, bu thas the error Compilation failure warnings found and -Werror specified

@ashleymercer
Copy link
Collaborator

Hi @SyCode7! Firstly, apologies for the delay in replying: as you can imagine, the last couple of weeks have been a bit busy / stressful...

Can you please confim the following?

  • which operating system you're on
  • which version of maven you're running
  • which version of Java you're using to compile

Can you also please copy-paste the warning messages from the build log into a comment here? That should help me track down what the issue is.

@ashleymercer
Copy link
Collaborator

Hi @SyCode7 - did you still need help with this?

@SyCode7
Copy link
Author

SyCode7 commented Nov 9, 2020

@ashleymercer , sorry I didn't try your solution yet, I directly used AWS XRay, via AWS SDK. Not sure if your library will provide some better results. This was the question I asked on stackoverflow https://stackoverflow.com/q/61025977/3398989

What do you think?

@ashleymercer
Copy link
Collaborator

The main two benefits of working against the OpenTracing API, as opposed to directly against the X-Ray API, are:

  1. you're using third-party libraries / SDKs which already post metrics to the OpenTracing API
  2. you want to switch out the underlying tracing implementation (e.g. you want to send traces to Jaeger or Zipkin instead of X-Ray)

You haven't mentioned (1) as a requirement, and for (2) it sounds like your app is fairly heavily integrated with AWS anyway, so if you have a working solution using the AWS SDK then I would stick with that.

I'm happy to investigate the original issue (compilation warnings) if you're able to provide the JDK version and OS you were compiling with? Or are you happy for me to close this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants