Fix issues in SiriAzure initialization #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove duplicate retry logic - Make sure that primed status is set correctly
habrahamsson-skanetrafiken
added
Skanetrafiken
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5760 +/- ##
=============================================
+ Coverage 67.79% 67.80% +0.01%
- Complexity 16519 16520 +1
=============================================
Files 1904 1905 +1
Lines 72263 72247 -16
Branches 7438 7440 +2
=============================================
Hits 48990 48990
+ Misses 20754 20739 -15
+ Partials 2519 2518 -1 ☔ View full report in Codecov by Sentry. |
jtorin
suggested changes
Mar 20, 2024
src/ext/java/org/opentripplanner/ext/siri/updater/azure/AbstractAzureSiriUpdater.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/siri/updater/azure/AbstractAzureSiriUpdater.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/siri/updater/azure/SiriAzureETUpdater.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/siri/updater/azure/SiriAzureSXUpdater.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/siri/updater/azure/SiriAzureETUpdater.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/siri/updater/azure/SiriAzureSXUpdater.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/framework/io/OtpHttpClientStatusCodeException.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Johan Torin <[email protected]>
|
Note: |
jtorin
previously approved these changes
Mar 21, 2024
habrahamsson-skanetrafiken
force-pushed
the
fix-azure-siri-updater-history
branch
from
8951628 to
267d3b7
Compare
leonardehrenfried
previously approved these changes
Mar 22, 2024
src/ext/java/org/opentripplanner/ext/siri/updater/azure/AbstractAzureSiriUpdater.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/siri/updater/azure/AbstractAzureSiriUpdater.java
Outdated
Show resolved
Hide resolved
…ctAzureSiriUpdater.java Co-authored-by: Leonard Ehrenfried <[email protected]>
leonardehrenfried
approved these changes
Mar 25, 2024
jtorin
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After discussions in the developer meeting this PR changes the OtpHttpClient to treat all 2xx http codes as successful and also adds a
executeAndMapOptional()method to the OtpHttpClient.Other than that there are only changes the SiriAzure sandbox code.
The changes in the SiriAzure code restructure some of the code in order to:
Unit tests
This kind of high level glue code is unfortunately hard to test without doing a lot of mocking.
Bumping the serialization version id
Nope