Add Bikeep bicycle parking updater #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5798 +/- ##
=============================================
+ Coverage 67.89% 67.90% +0.01%
- Complexity 16556 16563 +7
=============================================
Files 1908 1910 +2
Lines 72341 72398 +57
Branches 7440 7440
=============================================
+ Hits 49117 49165 +48
- Misses 20702 20712 +10
+ Partials 2522 2521 -1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
bikeep
branch
2 times, most recently
from
66f4709 to
7623a7b
Compare
leonardehrenfried
force-pushed
the
bikeep
branch
from
7623a7b to
f2a76c2
Compare
optionsome
previously approved these changes
Apr 18, 2024
docs/sandbox/VehicleParking.md
Outdated
| | Config Parameter | Type | Summary | Req./Opt. | Default Value | Since | | ||
| |----------------------------------|:---------------:|----------------------------------------------------------------------------|:----------:|---------------|:-----:| | ||
| | type = "vehicle-parking" | `enum` | The type of the updater. | *Required* | | 1.5 | | ||
| | [feedId](#u__13__feedId) | `string` | The name of the data source. | *Required* | | 2.2 | |
There was a problem hiding this comment.
This "name of the data source" is repeated in parking updater docs, maybe call it id instead of name.
There was a problem hiding this comment.
I've updated it in 091e4ed
Do you think that is a better way to explain it?
optionsome
approved these changes
Apr 23, 2024
t2gran
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a parking updater for the Estonian company Bikeep. This is a pure sandbox feature and only needs a single reviewer.
Unit tests
Added.
Documentation
Added.
cc @tsobuskerudbyen