Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORCA Fares: Add free cash transfers for Kitsap transit #5826

Merged

Conversation

daniel-heppner-ibigroup
Copy link
Contributor

Summary

Kitsap Transit allows cash users to have free transfers. This modification to the fare module allows us to keep track of cash transfer value per-agency instead of only for the itinerary as a whole.

Unit tests

The tests were modified to check the Kitsap cash transfer policy and to ensure that it doesn't collide with KC Metro cash transfers.

@daniel-heppner-ibigroup daniel-heppner-ibigroup requested a review from a team as a code owner May 2, 2024 22:14
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (0859b64) to head (e33d710).
Report is 3 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5826   +/-   ##
==========================================
  Coverage      67.90%   67.91%           
+ Complexity     16567    16559    -8     
==========================================
  Files           1910     1910           
  Lines          72418    72436   +18     
  Branches        7444     7447    +3     
==========================================
+ Hits           49173    49192   +19     
  Misses         20724    20724           
+ Partials        2521     2520    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried merged commit f4f1e39 into opentripplanner:dev-2.x May 6, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request May 6, 2024
@leonardehrenfried
Copy link
Member

Since this is a sandbox-only PR I used my admin rights to merge with a single review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants