Add prettier:write to docs and rephrase slightly [ci skip] #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
previously approved these changes
May 6, 2024
t2gran
reviewed
May 7, 2024
| % mvn prettier:write | ||
|
|
||
| ``` | ||
|
|
||
| To skip the prettier formating use profile `prettierSkip`: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Would you mind @abyrd changing line 41, it is a copy&paste error there. It should be mvn test -P prettierCheck (not prettierSkip).
Everything else looks fine.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5831 +/- ##
==========================================
Coverage 67.90% 67.90%
- Complexity 16556 16558 +2
==========================================
Files 1910 1910
Lines 72436 72436
Branches 7447 7447
==========================================
+ Hits 49190 49191 +1
Misses 20724 20724
+ Partials 2522 2521 -1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
May 7, 2024
t2gran
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to docs explaining how to perform only formatting.