Update Date/Time Selector #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
requested changes
Nov 14, 2024
BREAKING CHANGE: Replaces the old d/t selector in favor of new design
miles-grant-ibigroup
requested changes
Dec 5, 2024
| > | ||
| <S.DateTimeSelector.DepartureRow> | ||
| <Dropdown alignMenuLeft id="date-time-depart-arrive" text={departureOptions.find(opt => opt.isSelected).text} buttonStyle={{ backgroundColor: S.baseColor() || blue[900], borderRadius: "3px 0px 0px 3px", color: "white", height: "45px", border: "0px", padding:"5px 7px" }}> |
There was a problem hiding this comment.
Can we make the default gray instead of blue?
There was a problem hiding this comment.
Also some of these values are pretty fixed and are causing layout problems in some implementations. Any way we can make this more reactive to its environment?
Comment on lines
+150
to
+152
| departureOptions.forEach(opt => { | ||
| opt.isSelected = departArrive === opt.type; | ||
| }); |
There was a problem hiding this comment.
This works but it's pretty inefficient... Anyway we can replace/generate isSelected when we're iterating through the array anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the D/T selector styling so that date time inputs are always visible, and the departure option (leave now, depart at, arrive by) is a dropdown.
If a user updates the date or time input when the option "leave now" is selected, the dropdown will change to "depart at".