Compilation error (Werror) due to ignoring return value.

[xkszltl]

Describe the bug

Issue released in 1.18.0 tag introduced by:

• a86933e

#33 157.6 ucs/arch/test_x86_64.cc: In member function ‘void test_arch::nt_buffer_transfer_test(ucs_arch_memcpy_hint_t)’:
#33 157.6 ucs/arch/test_x86_64.cc:85:23: error: ignoring return value of ‘int posix_memalign(void**, size_t, size_t)’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
#33 157.6    85 |         posix_memalign((void **)&test_window_src, align, total_size);
#33 157.6       |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#33 157.6 ucs/arch/test_x86_64.cc:86:23: error: ignoring return value of ‘int posix_memalign(void**, size_t, size_t)’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
#33 157.6    86 |         posix_memalign((void **)&test_window_dst, align, total_size);
#33 157.6       |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#33 157.6 ucs/arch/test_x86_64.cc:87:23: error: ignoring return value of ‘int posix_memalign(void**, size_t, size_t)’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
#33 157.6    87 |         posix_memalign((void **)&dup, align, total_size);
#33 157.6       |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#33 157.6 cc1plus: all warnings being treated as errors

ucx/test/gtest/ucs/arch/test_x86_64.cc

Lines 85 to 87 in 1c1b1bd

	posix_memalign((void **)&test_window_src, align, total_size);
	posix_memalign((void **)&test_window_dst, align, total_size);
	posix_memalign((void **)&dup, align, total_size);

Steps to Reproduce

• Command line
  • https://github.com/xkszltl/Roaster/blob/2ef538860fb3a12719ee149b03054af9041b6e9e/pkgs/ucx.sh#L37-L59

  •   ./autogen.sh
      ./configure                     \
          --disable-assertions        \
          --disable-logging           \
          --disable-params-check      \
          --enable-backtrace-detail   \
          --enable-compiler-opt=3     \
          --enable-devel-headers      \
          --enable-doxygen-doc=no     \
          --enable-doxygen-dot=no     \
          --enable-doxygen-man=no     \
          --enable-examples           \
          --enable-gtest              \
          --enable-mt                 \
          --enable-ucg=no             \
          --prefix="$INSTALL_ABS"     \
          --with-avx                  \
          "$(sed 's/\(..*\)/--with-cuda=\1/' <<< "$cuda_root")"   \
          --with-gdrcopy=no           \
          "$(javac -version > /dev/null && echo '--with-java')"
    
      make all docs -j$(nproc)
      make install -j

• UCX version used (from github branch XX or release YY) + UCX configure flags (can be checked by ucx_info -v)
  • v1.18.0
  • See configuration in commands.

Setup and versions

• OS version (e.g Linux distro) + CPU architecture (x86_64/aarch64/ppc64le/...)
  • Ubuntu 22.04, x86_64.

[yosefe]

@edgargabriel @arun-chandran-edarath can you pls take a look? Ideally we'd like to add a test that reproduces the issue to builds.sh and backport the fix to v1.18.x

[arun-chandran-edarath]

@yosefe I will take a look. Thanks