add support for model outputs without names #2850
Open
+179
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzegla
reviewed
Dec 18, 2024
| try { | ||
| OV_LOGGER("ov::Output<ov::Node> output: {}, output.get_any_name()", reinterpret_cast<const void*>(&output)); | ||
| if (output.get_names().size() == 0) { | ||
| std::unordered_set<std::string> dummy_name{"OUT_" + std::to_string(outputIndex)}; |
There was a problem hiding this comment.
Shouldn't we use lowercase? Isn't it a standard in input/output naming?
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
There was a problem hiding this comment.
Is this script meant to be used only manually by developers?
There was a problem hiding this comment.
this is a reference how the test model got created in case some changes should be applied.
|
|
||
| input_data = np.ones((1, 10),dtype=np.int8)*10 | ||
| results = compiled_model({"INPUT1": input_data, "INPUT2": input_data}) | ||
|
|
There was a problem hiding this comment.
Maybe we could have some assertion here instead of prints?
I suppose the goal of this script is to generate a model and check if it's valid. In such case checking if output looks as expected would be good.
atobiszei
reviewed
Dec 18, 2024
| try { | ||
| OV_LOGGER("ov::Output<ov::Node> output: {}, output.get_any_name()", reinterpret_cast<const void*>(&output)); | ||
| if (output.get_names().size() == 0) { | ||
| std::unordered_set<std::string> dummy_name{"OUT_" + std::to_string(outputIndex)}; | ||
| output.add_names(dummy_name); |
There was a problem hiding this comment.
This is not logic related to "applyLayoutConfiguration". Move those changes outside of this method.
| @@ -0,0 +1,55 @@ | |||
| # | |||
| # Copyright (c) 2020 Intel Corporation | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-159002
When models have outputs without assigned names, add the name in the model initialization. The following format will be applied OUT_
🧪 Checklist
``