[Good First Issue]: Align behavior of ONNX Frontend function Relu-6, 13, 14 with original framework

[gkrivor]

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.
OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.
This task requires alignment between OpenVINO ONNX Frontend and original framework implementations of Relu for next list of opsets: opset 6, opset 13, opset 14
Necessary help will be provided by ONNX Fronted team.

What needs to be done?

Operator details can be found in ONNX Operators
More details can be found in ONNX Changelog: opset 6, opset 13, opset 14

1. Function already has a common implementation in OpenVINO. First of all, you need to review a documentation and prepare a table with differences between versions. It could be, for instance, a missing property, extended/reduced coverage of existing property, etc...
2. Copy existing implementation here to make it aligned with original framework (extend or reduce coverage of a common implementation). Copy of modified implementation should be in a defined opset, or in opset 1 in case it implements oldest implementation. Example of multi-opset operation.
3. Register the function in ops_bridge.cpp while keeping alphabetical order
4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
5. Add tests covering all use cases here
6. Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test".
   More details in adding operators to ONNX Frontend guide

Example Pull Requests

No response

Resources

• Contribution guide - start here!
• Intel DevHub Discord channel - engage in discussions, ask questions and talk to OpenVINO developers
• What is OpenVINO?
• User documentation
• Guides on ONNX Frontend architecture and ONNX Frontend tests are also available
• You can also see a blog post on contributing to OpenVINO

Contact points

@gkrivor

Ticket

No response

[Aryan8912]

please assign to me so I can working on this issue

[Aryan8912]

please give me file location to me

[p-wysocki]

Hello @Aryan8912, please start with the "What needs to be done" section, together with Contribution Guide from "Resources" section. :)

[Aryan8912]

Can't find it in discussions brother

[p-wysocki]

Hello @Aryan8912, I'm afraid I don't quite understand your question. The task regards finding out what the differences between different Relu implementations are and fixing them. The 1st point of TODO list contains: "Function already has a common implementation in OpenVINO."

Are you looking for the file where Relu is implemented in OpenVINO?

[Aryan8912]

Yes brother

[p-wysocki]

I believe @gkrivor meant OpenVINO implementation (as opposed to ONNX Frontend implementation). Relu can be found under https://github.com/openvinotoolkit/openvino/blob/master/src/core/src/op/relu.cpp.

[p-wysocki]

Hi @Aryan8912, are you still working on the task?

[Aryan8912]

Yes please give me some time bro

[Aryan8912]

hey Sir, I have made a pull request , I am not able to understand what is the problem with this PR of mine. please help me out

[RitikaxShakya]

Hello, is this issue open? if so can i take up this issue?

[mlukasze]

let's give a chance to current assignee, but I will remember about you

[AJThePro99]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[janviisonii23]

Is someone working on this issue ? If not can I work on this issue? @mlukasze

[mlukasze]

hey @AJThePro99 are you making any progress? do you need support maybe? or you don't have time to continue?

[AJThePro99]

hey @AJThePro99 are you making any progress? do you need support maybe? or you don't have time to continue?

Hi @mlukasze, I was intending to work on this issue. But the current issue #20547 that I'm working on, my progress was delayed due to dependency issues.
It's back on track, and I expect it to be merged after I open a new PR.

You can unassign me from this issue 👍

[mlukasze]

thanks for quick update!
you are right, let's focus on one ticket at the time, there will be planty more later :)

@janviisonii23 assigning this one to you