Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Expose Tensor.isContinuous() functionality #27701

Open
almilosz opened this issue Nov 22, 2024 · 7 comments · May be fixed by #27710
Open

[Good First Issue]: Expose Tensor.isContinuous() functionality #27701

almilosz opened this issue Nov 22, 2024 · 7 comments · May be fixed by #27710
Assignees
@nashez
Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers no_stale Do not mark as stale

Comments

@almilosz
Copy link
Contributor

almilosz commented Nov 22, 2024 •
edited
Loading

Context

OpenVINO works in Node.js environment!
We are looking for new contributors who can help with enabling C++ API methods
in JavaScript side.

First of all read Node.js API Contribution Guide.

Task Details

Expose ov::Tensor::is_continuous() method.
From JavaScript side it will be ov.isContinuous() method.

Useful links

What needs to be done?

How to take this issue

To take this issue leave text: .take as the comment in this issue.
It will assign this issue to you automatically. Please, make sure that the issue has the status Contributors Needed and doesn't have another user in Assingnees.

Example Pull Requests

Resources

Contact points

@almilosz @vishniakov-nikolai

Please, mention us in this issue discussion if you have any questions.
@almilosz almilosz added good first issue Good for newcomers no_stale Do not mark as stale labels Nov 22, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Nov 22, 2024
@almilosz almilosz added the category: JS API OpenVino JS API Bindings label Nov 22, 2024
@nashez
Copy link
Contributor

nashez commented Nov 23, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

nashez added a commit to nashez/openvino that referenced this issue Nov 23, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
bd45732 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
@nashez nashez linked a pull request Nov 23, 2024 that will close this issue
Open
nashez added a commit to nashez/openvino that referenced this issue Nov 24, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
29840b8 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
@mlukasze mlukasze moved this from Contributors Needed to In Review in Good first issues Nov 25, 2024
nashez added a commit to nashez/openvino that referenced this issue Nov 25, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
4db89e0 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
@sahil07-rg
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

@nashez
Copy link
Contributor

nashez commented Dec 9, 2024

Hi @sahil07-rg I am still working on this issue and the PR is open

Just a few open comments I need to resolve on the PR

I shall resolve it all by today

@nashez
Copy link
Contributor

nashez commented Dec 9, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

nashez added a commit to nashez/openvino that referenced this issue Dec 9, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
0bd54fc 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Dec 9, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
6ca97ec 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Dec 11, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
1d0dbeb 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Dec 12, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
6450c34 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Dec 12, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
5366f65 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Dec 19, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
17975ad 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Dec 25, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
b11e0e9 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
nashez added a commit to nashez/openvino that referenced this issue Dec 28, 2024
@nashez
[OV][JS] Expose the Tensor.isContinuous to Node.js API
1ac87a6 
* Add a TensorWrap::is_continuous function:
  Calls the underlying Tensor.isContinous function
* Update the addon.ts file with the isContinuous method
* Add unit tests for the isContinuous Api

Closes: openvinotoolkit#27701

Signed-off-by: Nashez Zubair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashez nashez

Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers no_stale Do not mark as stale
Projects
Good first issues
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OV][JS] Expose the Tensor.isContinuous to Node.js API nashez/openvino
3 participants
@nashez @almilosz @sahil07-rg