-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[NPU] Support for dynamic strides #32634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2faaba1 to
81ae163
Compare
Signed-off-by: Bogdan Pereanu <[email protected]>
81ae163 to
78f8f6c
Compare
Signed-off-by: Bogdan Pereanu <[email protected]>
78f8f6c to
b08fd27
Compare
Signed-off-by: Bogdan Pereanu <[email protected]>
Signed-off-by: Bogdan Pereanu <[email protected]>
b08fd27 to
263da19
Compare
| ov::CompiledModel compiled_model; | ||
| auto model = createModel(element::f32, shape, "N..."); | ||
|
|
||
| configuration[ov::intel_npu::inputs_with_dynamic_strides.name()] = {1}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We index IO from 0 so both inputs_with_dynamic_strides and outputs_with_dynamic_strides should be set to {0}
|
|
||
| _logger.debug("setGraphArgumentValue - perform pfnSetArgumentValue2 for strides"); | ||
| auto result = | ||
| _zeroInitStruct->getGraphDdiTable().pfnSetArgumentValue2(graphDescriptor._handle, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to set it in one go together with data pointer
| ze_graph_properties_3_t graphProperties = {}; | ||
| graphProperties.stype = ZE_STRUCTURE_TYPE_GRAPH_PROPERTIES; | ||
| graphProperties.pNext = &graphArgumentPropertyStrides; | ||
| auto result = _zeroInitStruct->getGraphDdiTable().pfnGetProperties3(graphDescriptor._handle, &graphProperties); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dynamic strides support is indicated for each argument. pfnGetProperties3 won't fill in this structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file is missing the code to calculate start address of the ROI tensor.
Details:
Tickets: