Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAL] Use python descriptors for properties #2324

Open
JeffreyDevloo opened this issue Jul 24, 2019 · 0 comments
Open

[DAL] Use python descriptors for properties #2324

JeffreyDevloo opened this issue Jul 24, 2019 · 0 comments

Comments

@JeffreyDevloo
Copy link
Contributor

JeffreyDevloo commented Jul 24, 2019

All properties are currently set onto the object when it is instantiated.
This makes it very hard for the editor to know which properties are set onto the object.

Instead of the dynamic property setting, we could use 'descriptors'

An example on how to implement can be found on my branch. Object defintion is more readable and the IDE can track the attributes because they are bound to the class.
The associated test suite should be expanded when further implementing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant