External RabbitMQ issues partition issue which isn't true

[matthiasdeblock]

Problem description

RabbitMQ is triggering a partition issue while it should trigger something else:

[INFO] Storagerouter Id: qsjZ10r5Wv2RBwEM
[INFO] Environment Os: Ubuntu 16.04 xenial
[INFO] Hostname: stor-01.ds1
[INFO] Cluster Id: IOip4i7eYCoH7W6f
[INFO] Storagerouter Type: MASTER
[INFO] Starting OpenvStorage Healthcheck version 3.4.0-1
[INFO] ======================
[INFO] Pre-check: verification of RabbitMQ cluster.
[FAILED] RabbitMQ has partition issues: STOP, RabbitMQ is not running.
[INFO] Recap of Health Check module ovs test verify-rabbitmq-test!
[INFO] ======================
[INFO] SUCCESS=0 FAILED=1 SKIPPED=0 WARNING=0 EXCEPTION=0

According to the code it should print another message when it is an externally managed RabbitMQ:

        if not RabbitMQ.INTERNAL:
            return 'UNKNOWN', "Unable to check the management plugin, this is not an internal RabbitMQ from ovs."

Workaround

Manually enable the rabbitmq_management worked for the externally managed rabbitMQ.

[matthiasdeblock]

@JeffreyDevloo , why is the check RabbitMQ.INTERNAL implemented? Can't we just make sure that it always enables the rabbitmq_management? Or was this for a certain reason?

[JeffreyDevloo]

Legacy most likely

[wimpers]

Since the whole conecpt of the HC is that it only detects problems and doesn't make any changes, I propose following:

• HC checks if internal or external RabbitMQ and reports accordingly
• If enable_management is off , return UNKNOWN and the correct error "Unable to check the management plugin, this is not an internal RabbitMQ from ovs."

[wimpers]

After discussion with @matthiasdeblock , it seems that the HC will enable the setting if it was disabled in case of an internally managed RabbitMQ. This violates the basic principle that the HC doesn't change anything in your environment. So what needs to happen

• In case internally managed the framework should during setup enable the plugin. (if not yet the case)
• In case externally managed, the ansible script enabled the plugin https://github.com/openvstorage/dev_ops/issues/92
• The path in the healthcheck to enbale the plugin should be removed
• HC checks if internal or external RabbitMQ and reports accordingly
• If enable_management is off , return UNKNOWN and the correct error "Unable to check the management plugin. Please enable the plugin."