Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Updates to Document Data Screen #797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UI Updates to Document Data Screen #797

wants to merge 1 commit into from

Conversation

dritan-x
Copy link
Contributor

  • Added warning message text, box, and icon
  • Showing document data fields according to a specified order defined in the code that matches the slides. Shows remaining fields in an unordered fashion.

Tested by:

  • Manual testing by adding Test eID-Karte Personalausweis
  • ./gradlew check
  • ./gradlew connectedCheck

Screenshot 2024-11-22 at 6 21 20 PM

Screenshot 2024-11-22 at 6 21 46 PM

@dritan-x dritan-x requested a review from kdeus November 23, 2024 02:27
kdeus
kdeus reviewed Nov 23, 2024
View reviewed changes
Copy link
Contributor

@kdeus kdeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I don't have any major concerns, just several small little details.

...java/com/android/identity_credential/wallet/ui/destination/document/DocumentDetailsScreen.kt Outdated Show resolved Hide resolved
...java/com/android/identity_credential/wallet/ui/destination/document/DocumentDetailsScreen.kt Outdated Show resolved Hide resolved
...java/com/android/identity_credential/wallet/ui/destination/document/DocumentDetailsScreen.kt Outdated Show resolved Hide resolved
...java/com/android/identity_credential/wallet/ui/destination/document/DocumentDetailsScreen.kt Outdated Show resolved Hide resolved
...java/com/android/identity_credential/wallet/ui/destination/document/DocumentDetailsScreen.kt Outdated Show resolved Hide resolved
@dritan-x
UI Updates to Document Data Screen
baf1ca2 
- Added warning message text, box, and icon
- Showing document data fields according to a specified order defined in the code that matches the slides. Shows remaining fields in an unordered fashion.

Tested by:
- Manual testing by adding Test eID-Karte Personalausweis
- ./gradlew check
- ./gradlew connectedCheck

Signed-off-by: dritan-x <[email protected]>
@dritan-x
Copy link
Contributor Author

@kdeus here are latest changes on this PR
Screenshot 2024-11-26 at 2 12 08 AM
Screenshot 2024-11-26 at 2 11 13 AM

@kdeus
Copy link
Contributor

kdeus commented Nov 26, 2024

Looks good. Thanks for the adjustments!
I'm going to hold off on merging this for a few days, since we just sent our Stage 2 submission and I want to leave the code untouched for any critical bugfixes. But I'll merge this in either next week or after the conference.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdeus kdeus kdeus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dritan-x @kdeus