fix: allows other algorithms to be used during the verification process #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mineme0110 <[email protected]>
|
@jovfer Please can you review this |
|
@tkuhrt Please can you review this request |
elribonazo
approved these changes
May 23, 2024
There was a problem hiding this comment.
LGTM, this provides the implementation with a little more flexibility on the crypto primitives that want to be used for sd+jwt.
Thanks for adding that @mineme0110
hamada147
approved these changes
May 23, 2024
goncalo-frade-iohk
approved these changes
May 23, 2024
jovfer
approved these changes
Jun 5, 2024
jovfer
reviewed
Jun 5, 2024
jovfer
force-pushed
the
fix-to-allow-other-sign-alg
branch
2 times, most recently
from
583327a
to
e566c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation defaults to the ES256 algorithm, causing other keys with different signature algorithms to fail during the verification process of the SDJWT.
This fix will make the signature algorithm flexible.
This flexibility will allow other algorithms, such as EdDSA, RSA etc to work.