Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo manager #64

Merged
merged 11 commits into from
Jan 9, 2024
Merged

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Dec 30, 2023

This PR ended up being larger than I thought.

Script:

  • Updated the script to handle spaces, comments and extra sections. Made small adjustment to oid4vci libraries. Upgraded askar to ~3.0 globally. Working really well.
  • Ran the script to update dependencies.
  • Removed the common development files part of the script. I thought they would be the same for every plugin but I'm already seeing them be customized in @Jsyro latest PR.
  • Made the script smaller and easier to maintain. Still a bit over work could be done to use the same code for the main vs integration test sections.

After upgrading all the plugins I had to fix some tests.

  • Moved the oid4vci unit tests to the inner project
  • Fixed a couple unit tests in multitenant_provider (not sure why these broke)
  • Fixed kafka_events integration tests after pytest upgrade.
  • Fixed multitenant_provider integration tests. There is currently an issue with the log file when agent run in multitenant admin mode.
  • Fixed redis events integration tests. Using basic_message storage which now requires it to be enabled.
  • changed test result files to be generated in the plugins so script can ignore that directory and just better to have them isolated.

All plugins are now using the same global packages.

@jamshale jamshale marked this pull request as ready for review January 9, 2024 20:26
Signed-off-by: jamshale <[email protected]>
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbluhm dbluhm merged commit d4b4cdf into openwallet-foundation:main Jan 9, 2024
3 checks passed
@jamshale jamshale deleted the update-repo-manager branch April 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants