Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proof request label #1325

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

al-rosenthal
Copy link
Contributor

Summary of Changes

  • Added typing to proof request fetch
  • Added logic to use V2 comments section as proof request name

Related Issues

BC-Wallet: 2125

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@al-rosenthal al-rosenthal marked this pull request as ready for review November 21, 2024 18:36
@al-rosenthal al-rosenthal changed the title Fix/proof request label fix: proof request label Nov 21, 2024
@MosCD3
Copy link
Contributor

MosCD3 commented Nov 25, 2024

can you update the branch and you are good to merge

Copy link

sonarcloud bot commented Nov 26, 2024

@jleach jleach merged commit 57bdf1b into openwallet-foundation:main Nov 26, 2024
7 checks passed
@al-rosenthal al-rosenthal deleted the fix/ProofRequestLabel branch November 26, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants