Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application crashes when trying to add/change gateway on Android 11+ #108

Open
olaquetal opened this issue Nov 27, 2022 · 3 comments
Open
Labels

Comments

@olaquetal
Copy link

Hello,
I installed the application on a new phone, samsung A52s with Android12.
Several issues noticed :

  • Adding an item light or automation is not possible because there is no default getway
  • Trying to access getway parameter crashes the application, android says it crashed because of a bug
  • The shared profiles from another accound doesn't appear

On another phone, same version of android, I have openwebnet which was the restore of my account form another phone, it works well but acessing the getway parameter also crashes the application.
Thanks a lot for help!
Antonio

@niqdev
Copy link
Member

niqdev commented Nov 28, 2022

Hi @olaquetal, thanks for reporting this.

About the profiles, I confirm that you can still apply existing profiles also on android 13, but that the sharing is not working at the moment. I can look into it, but I have very limited capacity at the moment. I've created a separate pr for this #109

I didn't notice it, but you are actually right, I've just tested it on android 11 and 13 and the app is actually closing/crashing when trying to add a gateway. So this is definitely a bug or a regression. Would you be able to debug and try to fix this? I haven't updated the app in a long time and I really don't have time to track this down. If you can look into it and open a pr, I'd be more than happy to test it and release a new version. Ideally, there should be 2 prs

  • update all the stable libs without breaking any existing functionalities
  • fix the gateway bug

Thanks again and please let me know if you can look into it otherwise, I can't make any promise on when I'll be able to fix it.

@niqdev niqdev added the bug label Nov 28, 2022
@niqdev niqdev changed the title Application crashes when trying to add/change getway on new installation Android 12 Application crashes when trying to add/change gateway on Android 11+ Nov 28, 2022
@olaquetal
Copy link
Author

Thanks again and please let me know if you can look into it otherwise, I can't make any promise on when I'll be able to fix it.

Hello @niqdev ,
Thank you for your confirmation it's a bug. Fortunately, it affects only new installations. Openwebnet still works on my phone.
I can try to look into it, I don't know if i'll be able to fix it, I've never developed on Android. I'll let you know.
Regards
Antonio

@niqdev
Copy link
Member

niqdev commented Nov 29, 2022

@olaquetal thanks for looking into it, I haven't looked at the code base in a while, but feel free to ask me for any help and review!

GatewayEditTextPreference should be the starting point. It's possible that is enough to bump the support libraries to solve the issue, it's definitely a regression and something changed in the recent version of android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants